EmmanuelDemey
commented
9 years ago Hi,
Which version of the plugin do you use ?
If you override these rules in your .eslintrc vile, you have to prefix them with 'angular/'
Manu
Closed bbohling closed 9 years ago
EmmanuelDemey
commented
9 years ago Hi,
Which version of the plugin do you use ?
If you override these rules in your .eslintrc vile, you have to prefix them with 'angular/'
Manu
bbohling
commented
9 years ago I have v0.0.6...I just installed it Friday. Below is my .eslintrc file. I include all options so devs do not have to look up documentation to customize to their needs...
{
// http://eslint.org/docs/rules/
"ecmaFeatures": {
"binaryLiterals": false, // enable binary literals
"blockBindings": false, // enable let and const (aka block bindings)
"defaultParams": false, // enable default function parameters
"forOf": false, // enable for-of loops
"generators": false, // enable generators
"objectLiteralComputedProperties": false, // enable computed object literal property names
"objectLiteralDuplicateProperties": false, // enable duplicate object literal properties in strict mode
"objectLiteralShorthandMethods": false, // enable object literal shorthand methods
"objectLiteralShorthandProperties": false, // enable object literal shorthand properties
"octalLiterals": false, // enable octal literals
"regexUFlag": false, // enable the regular expression u flag
"regexYFlag": false, // enable the regular expression y flag
"templateStrings": false, // enable template strings
"unicodeCodePointEscapes": false, // enable code point escapes
"jsx": false // enable JSX
},
"env": {
"browser": false, // browser global variables.
"node": false, // Node.js global variables and Node.js-specific rules.
"amd": false, // defines require() and define() as global variables as per the amd spec.
"mocha": false, // adds all of the Mocha testing global variables.
"jasmine": false, // adds all of the Jasmine testing global variables for version 1.3 and 2.0.
"phantomjs": false, // phantomjs global variables.
"jquery": false, // jquery global variables.
"prototypejs": false, // prototypejs global variables.
"shelljs": false, // shelljs global variables.
},
"globals": {
"_": true,
"angular": true,
"console": true,
"Showdown": true
},
"plugins": [
"angular"
],
"rules": {
////////// AngularJS Style Guide Rules //////////
// https://github.com/Gillespie59/eslint-plugin-angular
"angular/ng_angularelement": 1, // angular.element method should be used instead of the $ or jQuery object
//"angular/ng_controller_as_route": 2, // use controllerAs syntax
"angular/ng_controller_name": 0, // controller naming convention. second parameter can be a regexp
"angular/ng_definedundefined": 2, // use the angular.isUndefined or angular.isDefined methods instead of using the keyword undefined
"angular/ng_di": [2, "function"], // DI should use the same syntax
"angular/ng_directive_name": 0, // directives naming convention. second parameter can be a regexp
"angular/ng_document_service": 2, // use AngularJS $document service instead of default document
"angular/ng_empty_controller": 2, // remove empty controllers
"angular/ng_filter_name": 0, // filter naming convention. second parameter can be a regexp
"angular/ng_interval_service": 2, // use AngularJS $interval instead of setInterval
"angular/ng_json_functions": 2, // use angular.fromJson/toJson instead of JSON.parse/stringify
"angular/ng_module_name": 0, // module naming convention. second parameter can be a regexp
"angular/ng_no_digest": 2, // scope's $digest() should not be used. use $apply instead
"angular/ng_no_jquery_angularelement": 2, // should not wrap angular.element object into jQuery()
"angular/ng_no_private_call": 2, // do not use AngularJS internals
"angular/ng_no_services": [2, ['$http', '$resource']], // services allowed only in AngularJS service
//"angular/ng_no_service_method": 2, // APPEARS TO BE NO LONGER AVAILABLE - prefer factory() method instead of service()
"angular/ng_on_watch": 2, // watch/on should be assigned to a variable to be deleted in a $detroy
"angular/ng_service_name": 0, // service naming convention
"angular/ng_timeout_service": 2, // use $timeout instead of setTimeout
"angular/ng_typecheck_array": 2, // use angular.isArray instead of (typeof [] === "[object Array]")
"angular/ng_typecheck_boolean": 2, // use angular.isBoolean instead of (typeof true === "[object Boolean]")
"angular/ng_typecheck_date": 2, // use angular.isDate instead of (typeof new Date() === "[object Date]")
"angular/ng_typecheck_function": 2, // use angular.isFunction instead of (typeof function(){} ==="[object Function]")
"angular/ng_typecheck_number": 2, // use angular.isNumber instead of (typeof 3 === "[object Number]")
"angular/ng_typecheck_object": 2, // use angular.isObject instead of (typeof {} === "[object Object]")
"angular/ng_typecheck_regexp": 2, // use angular.isRegexp instead of (toString.call(/^A/) === "[object RegExp]")
"angular/ng_typecheck_string": 2, // use angular.isString instead of (typeof "" === "[object String]")
"angular/ng_window_service": 2, // use $window instead of default window
////////// Possible Errors //////////
"no-comma-dangle": 0, // disallow trailing commas in object literals
"no-cond-assign": 0, // disallow assignment in conditional expressions
"no-console": 1, // disallow use of console (off by default in the node environment)
"no-constant-condition": 0, // disallow use of constant expressions in conditions
"no-control-regex": 0, // disallow control characters in regular expressions
"no-debugger": 0, // disallow use of debugger
"no-dupe-keys": 0, // disallow duplicate keys when creating object literals
"no-empty": 0, // disallow empty statements
"no-empty-class": 0, // disallow the use of empty character classes in regular expressions
"no-ex-assign": 0, // disallow assigning to the exception in a catch block
"no-extra-boolean-cast": 0, // disallow double-negation boolean casts in a boolean context
"no-extra-parens": 0, // disallow unnecessary parentheses (off by default)
"no-extra-semi": 0, // disallow unnecessary semicolons
"no-func-assign": 0, // disallow overwriting functions written as function declarations
"no-inner-declarations": 0, // disallow function or variable declarations in nested blocks
"no-invalid-regexp": 0, // disallow invalid regular expression strings in the RegExp constructor
"no-irregular-whitespace": 0, // disallow irregular whitespace outside of strings and comments
"no-negated-in-lhs": 0, // disallow negation of the left operand of an in expression
"no-obj-calls": 0, // disallow the use of object properties of the global object (Math and JSON) as functions
"no-regex-spaces": 0, // disallow multiple spaces in a regular expression literal
"no-reserved-keys": 0, // disallow reserved words being used as object literal keys (off by default)
"no-sparse-arrays": 0, // disallow sparse arrays
"no-unreachable": 0, // disallow unreachable statements after a return, throw, continue, or break statement
"use-isnan": 0, // disallow comparisons with the value NaN
"valid-jsdoc": 0, // Ensure JSDoc comments are valid (off by default)
"valid-typeof": 0, // Ensure that the results of typeof are compared against a valid string
////////// Best Practices //////////
"block-scoped-var": 0, // treat var statements as if they were block scoped (off by default)
"complexity": 0, // specify the maximum cyclomatic complexity allowed in a program (off by default)
"consistent-return": 0, // require return statements to either always or never specify values
"curly": 0, // specify curly brace conventions for all control statements
"default-case": 0, // require default case in switch statements (off by default)
"dot-notation": 0, // encourages use of dot notation whenever possible
"eqeqeq": 0, // require the use of === and !==
"guard-for-in": 0, // make sure for-in loops have an if statement (off by default)
"no-alert": 0, // disallow the use of alert, confirm, and prompt
"no-caller": 0, // disallow use of arguments.caller or arguments.callee
"no-div-regex": 0, // disallow division operators explicitly at beginning of regular expression (off by default)
"no-else-return": 0, // disallow else after a return in an if (off by default)
"no-empty-label": 0, // disallow use of labels for anything other then loops and switches
"no-eq-null": 0, // disallow comparisons to null without a type-checking operator (off by default)
"no-eval": 0, // disallow use of eval()
"no-extend-native": 0, // disallow adding to native types
"no-extra-bind": 0, // disallow unnecessary function binding
"no-fallthrough": 0, // disallow fallthrough of case statements
"no-floating-decimal": 0, // disallow the use of leading or trailing decimal points in numeric literals (off by default)
"no-implied-eval": 0, // disallow use of eval()-like methods
"no-iterator": 0, // disallow usage of __iterator__ property
"no-labels": 0, // disallow use of labeled statements
"no-lone-blocks": 0, // disallow unnecessary nested blocks
"no-loop-func": 0, // disallow creation of functions within loops
"no-multi-spaces": 0, // disallow use of multiple spaces
"no-multi-str": 0, // disallow use of multiline strings
"no-native-reassign": 0, // disallow reassignments of native objects
"no-new": 0, // disallow use of new operator when not part of the assignment or comparison
"no-new-func": 0, // disallow use of new operator for Function object
"no-new-wrappers": 0, // disallows creating new instances of String, Number, and Boolean
"no-octal": 0, // disallow use of octal literals
"no-octal-escape": 0, // disallow use of octal escape sequences in string literals, such as var foo = "Copyright \251";
"no-process-env": 0, // disallow use of process.env (off by default)
"no-proto": 0, // disallow usage of __proto__ property
"no-redeclare": 0, // disallow declaring the same variable more then once
"no-return-assign": 0, // disallow use of assignment in return statement
"no-script-url": 0, // disallow use of javascript: urls.
"no-self-compare": 0, // disallow comparisons where both sides are exactly the same (off by default)
"no-sequences": 0, // disallow use of comma operator
"no-unused-expressions": 0, // disallow usage of expressions in statement position
"no-void": 0, // disallow use of void operator (off by default)
"no-warning-comments": 0, // disallow usage of configurable warning terms in comments, e.g. TODO or FIXME (off by default)
"no-with": 0, // disallow use of the with statement
"radix": 0, // require use of the second argument for parseInt() (off by default)
"vars-on-top": 0, // requires to declare all vars on top of their containing scope (off by default)
"wrap-iife": 0, // require immediate function invocation to be wrapped in parentheses (off by default)
"yoda": 0, // require or disallow Yoda conditions
////////// Strict Mode //////////
"global-strict": 0, // (deprecated) require or disallow the "use strict" pragma in the global scope (off by default in the node environment)
"no-extra-strict": 0, // (deprecated) disallow unnecessary use of "use strict"; when already in strict mode
"strict": 0, // controls location of Use Strict Directives
////////// Variables //////////
"no-catch-shadow": 0, // disallow the catch clause parameter name being the same as a variable in the outer scope (off by default in the node environment)
"no-delete-var": 0, // disallow deletion of variables
"no-label-var": 0, // disallow labels that share a name with a variable
"no-shadow": 0, // disallow declaration of variables already declared in the outer scope
"no-shadow-restricted-names": 0, // disallow shadowing of names such as arguments
"no-undef": 0, // disallow use of undeclared variables unless mentioned in a /*global */ block
"no-undef-init": 0, // disallow use of undefined when initializing variables
"no-undefined": 0, // disallow use of undefined variable (off by default)
"no-unused-vars": 0, // disallow declaration of variables that are not used in the code
"no-use-before-define": 0, // disallow use of variables before they are defined
////////// Node.js //////////
"handle-callback-err": 0, // enforces error handling in callbacks (off by default) (on by default in the node environment)
"no-mixed-requires": 0, // disallow mixing regular variable and require declarations (off by default) (on by default in the node environment)
"no-new-require": 0, // disallow use of new operator with the require function (off by default) (on by default in the node environment)
"no-path-concat": 0, // disallow string concatenation with __dirname and __filename (off by default) (on by default in the node environment)
"no-process-exit": 0, // disallow process.exit() (on by default in the node environment)
"no-restricted-modules": 0, // restrict usage of specified node modules (off by default)
"no-sync": 0, // disallow use of synchronous methods (off by default)
////////// Stylistic Issues //////////
"brace-style": 0, // enforce one true brace style (off by default)
"camelcase": 0, // require camel case names
"comma-spacing": 0, // enforce spacing before and after comma
"comma-style": 0, // enforce one true comma style (off by default)
"consistent-this": 0, // enforces consistent naming when capturing the current execution context (off by default)
"eol-last": 0, // enforce newline at the end of file, with no multiple empty lines
"func-names": 0, // require function expressions to have a name (off by default)
"func-style": 0, // enforces use of function declarations or expressions (off by default)
"key-spacing": 0, // enforces spacing between keys and values in object literal properties
"max-nested-callbacks": 0, // specify the maximum depth callbacks can be nested (off by default)
"new-cap": 0, // require a capital letter for constructors
"new-parens": 0, // disallow the omission of parentheses when invoking a constructor with no arguments
"no-array-constructor": 0, // disallow use of the Array constructor
"no-inline-comments": 0, // disallow comments inline after code (off by default)
"no-lonely-if": 0, // disallow if as the only statement in an else block (off by default)
"no-mixed-spaces-and-tabs": 0, // disallow mixed spaces and tabs for indentation
"no-multiple-empty-lines": 0, // disallow multiple empty lines (off by default)
"no-nested-ternary": 0, // disallow nested ternary expressions (off by default)
"no-new-object": 0, // disallow use of the Object constructor
"no-space-before-semi": 0, // disallow space before semicolon
"no-spaced-func": 0, // disallow space between function identifier and application
"no-ternary": 0, // disallow the use of ternary operators (off by default)
"no-trailing-spaces": 0, // disallow trailing whitespace at the end of lines
"no-underscore-dangle": 0, // disallow dangling underscores in identifiers
"no-wrap-func": 0, // disallow wrapping of non-IIFE statements in parens
"one-var": 0, // allow just one var statement per function (off by default)
"operator-assignment": 0, // require assignment operator shorthand where possible or prohibit it entirely (off by default)
"padded-blocks": 0, // enforce padding within blocks (off by default)
"quote-props": 0, // require quotes around object literal property names (off by default)
"quotes": [2, "single", "avoid-escape"], // specify whether double or single quotes should be used
"semi": 0, // require or disallow use of semicolons instead of ASI
"sort-vars": 0, // sort variables within the same declaration block (off by default)
"space-after-function-name": 0, // require a space after function names (off by default)
"space-after-keywords": 0, // require a space after certain keywords (off by default)
"space-before-blocks": 0, // require or disallow space before blocks (off by default)
"space-in-brackets": 0, // require or disallow spaces inside brackets (off by default)
"space-in-parens": 0, // require or disallow spaces inside parentheses (off by default)
"space-infix-ops": 0, // require spaces around operators
"space-return-throw-case": 0, // require a space after return, throw, and case
"space-unary-ops": 0, // Require or disallow spaces before/after unary operators (words on by default, nonwords off by default)
"spaced-line-comment": 0, // require or disallow a space immediately following the // in a line comment (off by default)
"wrap-regex": 0, // require regex literals to be wrapped in parentheses (off by default)
////////// ECMAScript 6 //////////
"no-var": 0, // require let or const instead of var (off by default)
"generator-star": 0, // enforce the position of the * in generator functions (off by default)
////////// Legacy //////////
"max-depth": 0, // specify the maximum depth that blocks can be nested (off by default)
"max-len": 0, // specify the maximum length of a line in your program (off by default)
"max-params": 0, // limits the number of parameters that can be used in the function declaration. (off by default)
"max-statements": 0, // specify the maximum number of statement allowed in a function (off by default)
"no-bitwise": 0, // disallow use of bitwise operators (off by default)
"no-plusplus": 0 // disallow use of unary operators, ++ and -- (off by default)
}
}Hi,
These two rules will available with the 0.0.7 release. This is not an issue in fact.
Manu
bbohling
commented
9 years ago Odd that you would have the 2 items in the 0.0.6 documentation and not call this a "bug". If they are not features until 0.0.7 I would content your documentation should not include them in the 0.0.6 docs or call it a bug. One or the other.
When will 0.0.7 be released?
EmmanuelDemey
commented
9 years ago You do not have these documentations on the 0.0.6 doc : https://www.npmjs.com/package/eslint-plugin-angular
The README.md file available on Github is for the 0.0.7 version. But you are maybe right. I should update the version of the package.json to somethink like 0.0.7-SNAPSHOT, to avoid misunderstanding.
Is it OK for you ?
Manu
bbohling
commented
9 years ago Gotcha...that makes sense. I guess my preference is to always have the master branch be the latest stable release. And then have feature/release branches. So in this repo's case master would be equivalent to 0.0.6 and then you would have a 0.0.7 branch where you were working on new features/bug fixes, whatever. Of course you can still have other branches that you merge into 0.0.7 (or other release branch). That way there is zero confusion when devs like myself start digging around readmes and branches. Of course this is only one of many common ways to manage repos. ;)
EmmanuelDemey
commented
9 years ago Perfect. You are totally right. We will follow this rule after the 0.0.7 release.
bbohling
commented
9 years ago Sounds excellent! Thank you for your efforts on this work!
I get "Definition for rule X not found" for the following 2 rules:
Is see them in the repo's code though and even used copy/paste to ensure exactness, but to no avail. What am I missing?