search

EmmanuelRoux / ngx-matomo-client

Matomo analytics client for Angular applications
https://matomo.org/
MIT License
74 stars 16 forks source link

`MatomoTestingTracker` is missing the `Injectable` decorator and causing warnings #85

Closed viceice closed 7 months ago

viceice commented 7 months ago

I get this warning when using the provideMatomoTesting provider helper:

DEPRECATED: DI is instantiating a token "MatomoTestingTracker" that inherits its @Injectable decorator but does not provide one itself.
This will become an error in a future version of Angular. Please add @Injectable() to the "MatomoTestingTracker" class.
EmmanuelRoux commented 7 months ago

Hi @viceice

you’re right, it’s a known "bug" (it should however work properly).

Feel free to open a PR, it should be ok to just add @Injectable() to this class

viceice commented 7 months ago

see linked PR 🙃

EmmanuelRoux commented 7 months ago

:tada: This issue has been resolved in version 6.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: