Crissov
commented
1 year ago Thank you for your contribution to this project! Sorry, this took so long to review. (I mostly check Github on my phone nowadays, but that’s unsuitable for a PR like this.)
I like the overall look of the cards. I’m a bit confused about the design of the 10s differing from the other value cards, but am not opposed to it.
It’s a bit absurd but consequential to support skin tone selection in the face cards. King 🤴 and Queen 👸 choices make absolute sense. For Jack, Adult Person 🧑 or Man 👨 is okay I guess. I think I would have gone with 💂 for the Knight/Cavalier instead of 🏇, but will accept it anyway.
Pips for face cards (K, Q, J and C) are of course Anglo-centric, but I don’t think there’re any accepted international symbols to use instead.
The trumps, which are not part of this PR, are complicated indeed, because mundane and arcane visualisations differ quite a lot. Unicode should figure this one out first, I guess.
Pertains to #107 but lacks trumps.
Based on existing images as much as possible, though the 9, 6 and clubs sign are modified to remain clearly distinct from the 8 and spades sign at such smaller sizes (compared to the keycap and suit-symbol emoji).