search

Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.
https://emory-hiti.github.io/Niffler/
BSD 3-Clause "New" or "Revised" License
90 stars 53 forks source link

Added dockerfile #263

Closed pramitsahoo closed 2 years ago

pramitsahoo commented 2 years ago

Added dockerfile in the png extraction module . i am complete newbie to docker as well as open source . please let me know how to improve or how to correct things , or how to actually make this thing work

pradeeban commented 2 years ago

Thanks for your attempt at this issue.

Please make the pull requests against the dev branch, following the guidelines listed in https://github.com/Emory-HITI/Niffler/blob/master/CONTRIBUTING.md

Also, png-extractor requires libraries such as gdcm. Please follow the comments in https://github.com/Emory-HITI/Niffler/issues/262

pradeeban commented 2 years ago

Running install.sh in the container as the first step is a quick fix to this shortcoming. Please do a test on a sample image (such as one that could be obtained from https://www.cancerimagingarchive.net/collections/ ) to confirm it is working, before committing the changes or creating a pull request. Also, please include a README instructions on how this could be run as a container so people could already start using your container.

Thank you.