search

Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.
https://emory-hiti.github.io/Niffler/
BSD 3-Clause "New" or "Revised" License
90 stars 53 forks source link

Pngextractiondev #280

Closed Pavan-Bellam closed 2 years ago

Pavan-Bellam commented 2 years ago

Supporting extraction of private tags.

pradeeban commented 2 years ago

I endorse this pull request. I will test tomorrow.

Pavan-Bellam commented 2 years ago

Thank you

pradeeban commented 2 years ago

When there is no "featureset.txt" present while " "PublicHeadersOnly": false, it throws the below error.

python3 ImageExtractor.py /Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pydicom/filereader.py:300: UserWarning: Expected explicit VR, but found implicit VR - using implicit VR for reading warnings.warn(message, UserWarning) Traceback (most recent call last): File "ImageExtractor.py", line 522, in initialize_config_and_execute(args) File "ImageExtractor.py", line 99, in initialize_config_and_execute failed, maps_directory, meta_directory, LOG_FILENAME, metadata_col_freq_threshold, t_start) File "ImageExtractor.py", line 398, in execute feature_list = open("featureset.txt").read().splitlines() FileNotFoundError: [Errno 2] No such file or directory: 'featureset.txt'

Can you please make a try-catch that will just get all the tags when featureset.txt is not found? I thought that is what you are doing from the README.

pradeeban commented 2 years ago

Also, I have left another comment regarding a Key Error in the code directly.

pradeeban commented 2 years ago

Hi,

258 is now fixed in the dev branch. But your pull request goes beyond that, also attempting to implement #282.

If you do a "git pull" from the dev branch and adapt your changes accordingly, with your existing progress, I believe you could easily implement #282.

Please make sure to keep a note of all your pull requests and contributions in your project proposal (even if they are not merged). Because these help highlight your strength in Python and DICOM.