search

Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.
https://emory-hiti.github.io/Niffler/
BSD 3-Clause "New" or "Revised" License
90 stars 53 forks source link

Pngextractiondev #283

Closed Pavan-Bellam closed 2 years ago

Pavan-Bellam commented 2 years ago

support for extraction of certain subset of dicom attributes

Pavan-Bellam commented 2 years ago

@pradeeban I have not added another header in the json file. Because if the user does not want those four attributes I think we should not force them to extract those also. As it is in my README if the user want certain attributes he must set the publicheadersonly to false and list the attributes in the featureset.txt file. I have also made the updates you asked me in other PR. Are there any other modifications?

pradeeban commented 2 years ago

Hi Pavan, Thanks for your contribution.

We need an attribute "SpecificHeadersOnly": false,

That helps us to make sure whether we need to look for a featureset.txt or not. Otherwise, you are leaving several corner cases to fail (like I tested in the previous pull request). I have detailed the test cases in #282 to follow through. Also, tieing "SpecificHeadersOnly" attribute to depend on the other 2 does not follow how we have designed the rest of Niffler (so it will confuse the users).

For example, when featureset.txt is not present, when it is present but empty, etc.

As I mentioned before, you should still include this contribution in your GSoC proposal. But if you like to fix #282, please create a new pull request (making sure you got the latest version of code from the Niffler dev branch).