Refactor system configuration parsing for improved Destination AE support

Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.

https://emory-hiti.github.io/Niffler/

BSD 3-Clause "New" or "Revised" License

90 stars 53 forks source link

Refactor system configuration parsing for improved Destination AE support #377

Closed yuvraj-wale closed 1 year ago

yuvraj-wale commented 1 year ago

This pull request addresses the comments and suggestions made in the code review.

linked to issue #133.

@pradeeban I feel this should work, if not do let me know, thanks.

yuvraj-wale commented 1 year ago

oh no that log was not supposed to be there, I am really sorry .Its is supposed to be in the if block above the "if not file_path == cfind_only and not file_path == cfind_detailed" lines of code, sorry Its all little new to me😅. apart from this log change is everything fine? @pradeeban

pradeeban commented 1 year ago

Are you a newbie to Python? What are your usual programming languages?

yuvraj-wale commented 1 year ago

I primarily use C++ and Dart (flutter) for programming, but I also know some basic Python. I wanted to learn more about this technology and its applications in machine learning and medical science because I am finding it quite fascinating.