Refactor system configuration parsing for improved Destination AE support

Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.

https://emory-hiti.github.io/Niffler/

BSD 3-Clause "New" or "Revised" License

90 stars 53 forks source link

Refactor system configuration parsing for improved Destination AE support #378

Closed yuvraj-wale closed 1 year ago

yuvraj-wale commented 1 year ago

made appropriate changes, should work now.

linked to issue #133

pradeeban commented 1 year ago

I have not tested this. But this PR does not have any obvious errors.

anbhimi commented 1 year ago

@pradeeban The PR passed all the unit and integration tests associated with the cold extraction module. The functionality could not be tested because of the reasons mentioned in #133 discussion.

As per the source code, the PR addresses the issue.

pradeeban commented 1 year ago

Thanks @anbhimi. I will merge to dev. It does not seem to break the existing functionality. Whether the case when we have a QueryAet that is different from DestAet will work with these changes - left to be tested.