Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.
https://emory-hiti.github.io/Niffler/
BSD 3-Clause "New" or "Revised" License
90 stars 53 forks source link

PNG-Extraction bugs: Missing Imports and Undeclared Variable Errors #389

Closed yuvraj-wale closed 1 year ago

yuvraj-wale commented 1 year ago

Describe the bug In the experimental slurm based implementation of png-extraction, there are two issues: the script is missing the subprocess import, and the t_start variable used is not declared.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'modules/png-extraction/ImageExtractorSlurm.py'
  2. Scroll down and checkout line 340 and 343
  3. See error

Expected behavior The script should not contain any errors.

Environment (please complete the following information):

Additional context While I was checking out how the module is containerized, I came across these errors.