search

Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.
https://emory-hiti.github.io/Niffler/
BSD 3-Clause "New" or "Revised" License
90 stars 53 forks source link

Containerizing meta-extraction module #392

Closed imiro closed 1 year ago

imiro commented 1 year ago

An attempt to #349 for meta-extraction module.

This runs well on my tests so far. One improvement I can think of is perhaps to offload a couple of parameters such as QueryAET, FilePath, or StorageFolder to environment variables instead of a json file to make configuring it more flexible, as “best practice” usually found in numerous container images. Please let me know if this is desired, I could perhaps put together a small script executed at startup that would rewrite system.json with values from environment variable, if exists.

pradeeban commented 1 year ago

Thanks, this is a good start. Since these are just introducing new files and not modifying anything existing, the commit won't break anything. We should make a Docker compose with containers for other related bundles, such as the MongoDB datastore for the metadata store.

imiro commented 1 year ago

Thanks @pradeeban. I think I used a locally created network with temporary containers when testing. I'll try to come up with a compose file.