Emory-HITI / Niffler

Niffler: A DICOM Framework for Machine Learning and Processing Pipelines.
https://emory-hiti.github.io/Niffler/
BSD 3-Clause "New" or "Revised" License
90 stars 53 forks source link

Rethinking how Niffler handles multiple query sources at once #406

Open pradeeban opened 1 year ago

pradeeban commented 1 year ago

Currently, we support querying multiple sources by running ColdDataRetriever twice (or more times), by changing these parameters in the system.json.

But the same Query AET can run multiple queries to multiple source AETs. So, we may rethink our approach and fix the implementation.

This will be especially useful if all the SourceAET only know and accept that one particular Niffler instance, defined by a Hostnmae, port, and AET as something like (x.x.x.x, 4242, QBNIFFLER).

pradeeban commented 1 year ago

Technically, it should be possible to just run Niffler twice with the same configs except for Src AET, to get data from two different destinations.

We put checks in place to make sure Niflfler is not mistakenly run twice by two different people, getting the data mixed up.

Probably, we just need another parameter to confirm the subsequent run is intentional.