EmotiBit / EmotiBit_FeatherWing

Firmware to run Emotibit with Adafruit feather M0 WiFi and Feather ESP32
MIT License
19 stars 9 forks source link

Fix ESP32 _dataFile.sync() #202

Open produceconsumerobot opened 2 years ago

produceconsumerobot commented 2 years ago

We either need to utilize SdFat library for ESP32 or find/create similar functionality for built-in SD library

nitin710 commented 2 years ago

Ok, i shall look into it!

Aslo, additional information in the issue description (like links to code segments) is always welcome!

produceconsumerobot commented 2 years ago

See https://github.com/greiman/SdFat/issues/325

produceconsumerobot commented 2 years ago

see also https://github.com/greiman/SdFat/issues/323 https://www.arduinolibraries.info/architecture-variants.html https://forum.arduino.cc/t/library-conflict-dont-know-how-to-resolve/861040/12

produceconsumerobot commented 2 years ago

If it's not reasonably easy to avoid SdFat conflicts on ESP, using _dataFile.flush() on ESP322 instead of _dataFile.sync() fixes the problem. It may be possible to only use .flush(), i.e. with both standard SD.h and SdFat.h, though possibly not worth the engineering to assess if there are any issues on M0, so a ToDo to assess may be the best agile path.