EmotiBit / EmotiBit_FeatherWing

Firmware to run Emotibit with Adafruit feather M0 WiFi and Feather ESP32
MIT License
19 stars 8 forks source link

Support data recording on Agave RevB #289

Closed nitin710 closed 4 days ago

nitin710 commented 7 months ago

Description

nitin710 commented 6 months ago

Found the bug. It was not an SD issue. It was actually a null pointer exception in printConfigInfo function.

the emotibitEda.writeInfoJson function https://github.com/EmotiBit/EmotiBit_FeatherWing/blob/a63cba341eff8a3320da21e9ee9a9d9ff34b779e/EmotiBit.cpp#L2671 has a null pointer, that is only allocated after emotibitEda.setup is called. But for Agave board, we skip setup. Therefore, that leaves a nullpointer in the emotibitEda class. https://github.com/EmotiBit/EmotiBit_FeatherWing/blob/a63cba341eff8a3320da21e9ee9a9d9ff34b779e/EmotiBitEda.cpp#L548

That was being called in printConfigInfo.

Suggested fix