EmotiBit / EmotiBit_FeatherWing

Firmware to run Emotibit with Adafruit feather M0 WiFi and Feather ESP32

MIT License

19 stars 8 forks source link

Fix agave record crash #292

Closed nitin710 closed 3 months ago

nitin710 commented 5 months ago

Description

Fixes MCU crash when record session is started on Agave-RevB
Fixes Record LED not blinking on EmotiBit (on the agave branch)

Requirements

PR #(Link PR)

Issues Referenced

Fixes #289

Documentation update

Link to a change in documentation (if any)

Notes for Reviewer

Add detailed notes explaining code changes, algorithms or any other information that can help the reviewer understand the PR better.

Testing

Results

Synopsis of results, details if required.

Feature Tests

Steps to test

Shared files

Firmware binary: [Link to firmware binary]
Other files.

Checklist to allow merge

[ ] All dependent repositories used were on branch master
Firmware
- [ ] Set testingMode to TestingMode::NONE
- [ ] Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
- [ ] Update version in EmotiBit.h
- [ ] Update library.properties to the correct version (should match EmotiBit.h)
[ ] doxygen style comments included for new code snippets
[ ] Required documentation updated

Screenshots:

nitin710 commented 3 months ago

Fix has been added to mainline FW. https://github.com/EmotiBit/EmotiBit_FeatherWing/pull/296