EmotiBit / ofxEmotiBit

OpenFrameworks library and examples for the EmotiBit

MIT License

33 stars 8 forks source link

Fix OSC output for aperiodic signals. #109

Closed nitin710 closed 1 year ago

nitin710 commented 2 years ago

Description

Aperiodic signals are not being periodized before being transmitted vis OSC.

Code

https://github.com/EmotiBit/ofxEmotiBit/blob/2ea8b07a6422bf42fcf4e0883b1729fe8752abb0/EmotiBitOscilloscope/src/ofApp.cpp#L1021-L1033

To recreate

Modify the oscOutputSetting.xml file in Oscilloscope to include HR patch
Modify the oscInputSettings.xml file in oscOscillosocpe example to include HR
Modify the ofxOscilloscopeSettings.xml file to include a new plot for HR

Example

nitin710 commented 2 years ago

Based on the latest discussion, we might not want to output periodized signals on OSC. periodization is being performed to conform to needs of the oscilloscope.

So, what might be the right answer for OSC?

nitin710 commented 1 year ago

We are going to let aperiodic signals be aperiodic outside Oscilloscope. closing this issue.