Fixes daylight savings time adjustment on dataparser.
Currently, in locations following day light savings time, there appears to be a 1 hour offset between time of recording and parsing.
Requirements
None
Issues Referenced
Fixes #98
Documentation update
None
Notes for Reviewer
Check #98 issue comments for more information on how this issue was fixed.
Testing
Results
The table below shows that parsing the same file with DST enabled/disabled creates the correct epoch times to get back to the local time captured in the filename.
Operating system
Daylight savings enabled
daylight savings disabled
Windows 10
macOS mojave
Linux Ubuntu 22.04
Feature Tests
DataParser: Handles daylight savings time shift correctly
Steps to test
Import the steps from the EmotiBit Feature Test Protocol for quick access for the reviewer
Checklist to allow merge
[ ] All dependent repositories used were on branch master
Software
[ ] Get approval from the reviewer
[ ] Passed testing on Windows
[ ] Passed testing on macOS (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
[ ] Passed testing on linux (ubuntu) (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
[ ] Update software bundle version in ofxEmotiBitVersion.h
Description
Requirements
Issues Referenced
Documentation update
None
Notes for Reviewer
Testing
Results
Feature Tests
Steps to test
Import the steps from the
EmotiBit Feature Test Protocol
for quick access for the reviewerChecklist to allow merge
master
ofxEmotiBitVersion.h
Screenshots: