EmotiBit / ofxEmotiBit

OpenFrameworks library and examples for the EmotiBit
MIT License
33 stars 7 forks source link

Fix firmware installer apple silicon fix #212

Closed nitin710 closed 11 months ago

nitin710 commented 1 year ago

Description

Requirements

Issues Referenced

Documentation update

Link to a change in documentation (if any)

Notes for Reviewer

Testing

Device M1 mac intel mac Windows
Feather M0 ✔️ (change to ofxSerial fixed desc/PID/VID) ✔️(was originally working) ✔️ No issues were flagged and the original logic still exists, so it should work just fine
Feather ESP32 ✔️ Tested working ✔️ Was originally working ✔️ No issues were flagged and the original logic still exists, so it should work just fine

Results

Stage Sreengrab
On Startup of app Screenshot 2023-06-08 at 11 28 42 AM
After pressing space Screenshot 2023-06-08 at 11 28 58 AM
Plugged in device Screenshot 2023-06-08 at 11 29 38 AM
Finished updating Screenshot 2023-06-08 at 11 30 03 AM

Feature Tests

Checklist to allow merge

Screenshots:

produceconsumerobot commented 1 year ago

Review 01

@nitin710 on brief review, my biggest question is whether this change affects the specificity of the ESP detection either on Apple or Intel silicon. Has the full silicon/Feather 2x2 testing matrix been run?

nitin710 commented 1 year ago

Esp32 on both intel and apple silicon has been tested. It is tested working.

The Feather M0 is a separate logic and is exclusive to this change. Hence it has not been tested.

nitin710 commented 1 year ago

On some testing run based on the comment about Feather M0, it was found that the Feather M0 also does not get detected on M1 macs. Will update the PR with a fix for that and also test results.