Closed nitin710 closed 1 year ago
@nitin710 on brief review, my biggest question is whether this change affects the specificity of the ESP detection either on Apple or Intel silicon. Has the full silicon/Feather 2x2 testing matrix been run?
Esp32 on both intel and apple silicon has been tested. It is tested working.
The Feather M0 is a separate logic and is exclusive to this change. Hence it has not been tested.
On some testing run based on the comment about Feather M0, it was found that the Feather M0 also does not get detected on M1 macs. Will update the PR with a fix for that and also test results.
Description
Requirements
Issues Referenced
Documentation update
Link to a change in documentation (if any)
Notes for Reviewer
Testing
Results
Feature Tests
Checklist to allow merge
master
ofxEmotiBitVersion.h
Screenshots: