EmotiBit / ofxEmotiBit

OpenFrameworks library and examples for the EmotiBit
MIT License
33 stars 7 forks source link

Feat lsl output #226

Closed produceconsumerobot closed 1 month ago

produceconsumerobot commented 5 months ago

Description

Notes to include with Release

The LSL output relays data for each EmotiBit stream plotted in the EmotiBit Oscilloscope. Please note, however, that the LSL timestamps are presently not corrected for the device-to-computer time-of-flight because this correction can require some degree of nuance for gracefully handling changes in the clock-to-clock estimation. Recording LSL Marker inputs with EmotiBit Oscilloscope followed by using the EmotiBit DataParser to parse raw data files recorded on the EmotiBit SD card provides the highest degree of timestamp accuracy to compare EmotiBit signals with signals from other devices.

ToDo

Requirements

Issues Referenced

Documentation update

[ToDo]

New files to be added with release

Notes for Reviewer

To achieve a draft/pre-release Windows installer, let's do a mini review testing functional on Windows. A more in-depth code review, complete testing notes and results across platforms as well as documentation update can be performed subsequently.

Testing

Results

[ToDo]

Feature Tests

● Oscilloscope UDP output ● Oscilloscope OSC output ● Oscilloscope LSL output ● Oscilloscope LSL Marker Input

Steps to test

All feature tests should be performed for each platform

Checklist to allow merge

Screenshots:

nitin710 commented 4 months ago

Review 01

nitin710 commented 4 months ago

See comments for lsl-viewer here

nitin710 commented 3 months ago

@produceconsumerobot Should I wait for a fix for this before testing? https://github.com/EmotiBit/ofxEmotiBit/issues/234

produceconsumerobot commented 3 months ago

@nitin710 you can test LSL streaming independent of the Markers issue

produceconsumerobot commented 3 months ago

from datalog.txt

887204,15942,8,LM,1,100,LR,542485.4,LM,542485.4,LC,542485.4,LD,Hello, 887326,15962,4,TX,1,100,LR,542485.4,LM,542485.4,LC,542485.4,LD,Hello,LC,542485.4,LM,542485.4, 887339,15963,4,TX,1,100,LR,542485.4,LM,542485.4,LC,542485.4,LD,Hello,LC,542485.4,LM,542485.4,TL,2024-03-22_12-11-53-155553,LC,542485.4,

LSL Marker packets from a working data file

387896,60604,8,LM,1,100,LR,207191.0339737,LM,405672.1322546,LC,207191.0798633,LD,1681684929.248634,30.00000000000000,1681684929.248634, 388265,60669,4,TX,1,100,LC,207191.0339737,LM,405672.1322546 388271,60670,4,TX,1,100,TL,2023-04-16_15-42-08-392790,LC,207191.0838676

@nitin710 this should be fixed now

nitin710 commented 3 months ago
nitin710 commented 3 months ago

This PR is already merged into dev. Will be merged to master once build on linux is resolved.