Fix discovered emotibits mutex

[produceconsumerobot]

Description

Attempt to fix read access violation with _discoveredEmotiBits https://github.com/EmotiBit/ofxEmotiBit/issues/231

Requirements

• https://github.com/EmotiBit/EmotiBit_XPlat_Utils/pull/26

Issues Referenced

• Closes #231

Documentation update

Link to a change in documentation (if any)

Notes for Reviewer

• Update new file structure in different OS project files
• Files changed
  • ofxOscilloscope/ofxPatchboard/Patchboard/src

List of new distributable files

none

Testing

• Let the oscilloscope run data from VS compiled for debug
• Get a coffee/beer/kombucha
• Periodically checked for read access violation

Results

• No read access violation observed

Feature Tests

none (it's possible we could add a stability test at some point, but it get's a bit laborious and under-defined)

Steps to test

See Testing above

Shared files

none

Checklist to allow merge

• [ ] All dependent repositories used were on branch master
• Software
  • [ ] Get approval from the reviewer
  • [ ] Passed testing on Windows
  • [ ] Passed testing on macOS (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
  • [ ] Passed testing on linux (ubuntu) (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
  • [ ] Update software bundle version in ofxEmotiBitVersion.h
• Firmware
  • [ ] Set testingMode to TestingMode::NONE
  • [ ] Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
  • [ ] Update version in EmotiBit.h
  • [ ] Update library.properties to the correct version (should match EmotiBit.h)
• [ ] doxygen style comments included for new code snippets
• [ ] Required documentation updated

Screenshots:

[nitin710]

Fix to PR description:

• This PR requires https://github.com/EmotiBit/EmotiBit_XPlat_Utils/pull/26
• Update new file structure in different OS project files (ofxOscilloscope/ofxPatchboard/Patchboard/src)

[nitin710]

Testing Build

Build OS	Build result
windows	✔️
mac	✔️
linux	❌

• Linux
  • Getting build error PatchBoardJson not found.
  • Added path ot file in config.make file
  • 
  • THen getting new error, ofMain.h not found when compiling ofxEmotiBit/src/EmotiBitOfUtils.h

[nitin710]

Tried adding path to file in config.make, but that did not resolve the error.

[nitin710]

This PR is already merged into dev. Will be merged to master once build on linux is resolved.

[nitin710]

LSL output was merged in master. See #239 .

This was an "intermediate" PR that was merged into dev as a part of a fast tracked release process. Consequently, it is now outdated and being closed.