EmotionCognitionLab / pvs

1 stars 0 forks source link

bug if user is looking at rewards when end-of-breathing-session-1 upload is occuring #315

Closed maramather closed 1 year ago

maramather commented 1 year ago

I had completed my first 15-min paced breathing session of the day, it was in the process of uploading my data when I used the menu to navigate to the rewards summary screen. I looked it over, then clicked on 'return'. It brought me to the 2nd paced-breathing session screen. I clicked on start, and it did nothing and eventually gave me an error message. I checked and emWave was not running.

It seems that instead of requiring quitting as it usually does between sessions, if the user goes to the reward screen while the first session data is uploading, quitting is not enforced and it messes things up.

noah10 commented 1 year ago

I think that we should just disable the earnings menu when you are on a breathing page - we really don't want users to be able to get distracted and go somewhere else when they're on that page.

maramather commented 1 year ago

I agree, that would work.

noah10 commented 1 year ago

OK - once the timer starts counting down (in rest breathing) or once the pacer starts running (in paced breathing) the View -> Earnings and View -> Daily Tasks menus will be disabled. They will stay disabled until you quit the app and run it again.

maramather commented 1 year ago

The menu was disabled as intended but it didn't appear to look any different from the other menu options (it was not greyed out as far as I could tell). If that is not possible to grey it out, that's fine, but if it is possible, that would improve the interface.

maramather commented 1 year ago

It is greyed out.