EmotionCognitionLab / pvs

1 stars 0 forks source link

change average coherence calculation #353

Closed noah10 closed 1 year ago

noah10 commented 1 year ago

The following changes should be made to the average coherence calculation:

@maramather and @HyunjooY , let me know if you see anything wrong or missing here.

maramather commented 1 year ago

That looks good to me!

HyunjooY commented 1 year ago

Looks good. One question, would this change be applied on the existing data?

noah10 commented 1 year ago

No, it would not. We do not have the information necessary to change the data retroactively. (Once we've calculated the average coherence score we throw away all of the intermediate values that we used to calculate it.)

HyunjooY commented 1 year ago

Got it. Thank you!

noah10 commented 1 year ago

By default the change to ignore the first 30 seconds of data (coherence values and artifacts) will apply to both rest breathing (i.e. stage 1 baseline and stage 2) and paced breathing. (Though the coherence score we display on-screen to the user will still update during the first 30 seconds - those values just won't be used to calculate the average coherence that we store in the database.) Is that a problem, @maramather or @HyunjooY ?

maramather commented 1 year ago

That is ok (I assume it is much simpler for your code).

HyunjooY commented 1 year ago

Yes. that is okay. Thank you!

noah10 commented 1 year ago

Unfortunately I've just discovered that I somehow totally missed the code change necessary to drop the minimum threshold for average coherence down to 360 values from 480 values. Re-opening.