Closed noah10 closed 1 year ago
That looks good to me!
Looks good. One question, would this change be applied on the existing data?
No, it would not. We do not have the information necessary to change the data retroactively. (Once we've calculated the average coherence score we throw away all of the intermediate values that we used to calculate it.)
Got it. Thank you!
By default the change to ignore the first 30 seconds of data (coherence values and artifacts) will apply to both rest breathing (i.e. stage 1 baseline and stage 2) and paced breathing. (Though the coherence score we display on-screen to the user will still update during the first 30 seconds - those values just won't be used to calculate the average coherence that we store in the database.) Is that a problem, @maramather or @HyunjooY ?
That is ok (I assume it is much simpler for your code).
Yes. that is okay. Thank you!
Unfortunately I've just discovered that I somehow totally missed the code change necessary to drop the minimum threshold for average coherence down to 360 values from 480 values. Re-opening.
The following changes should be made to the average coherence calculation:
@maramather and @HyunjooY , let me know if you see anything wrong or missing here.