EmotionalLove / ReMinecraft

Starting life on another server
GNU Lesser General Public License v3.0
29 stars 7 forks source link

Suggestion: add an option to remove "\0FML\0" from the handshake. #33

Open douglasb78 opened 4 years ago

douglasb78 commented 4 years ago

Some servers owners think it's fine to ban forge mods and that players wouldn't miss anything. However this is a dumb move: you lose many server players while cheaters continue playing on it.

code: https://github.com/MinecraftForge/MinecraftForge/blob/ebe9b6d4cbc4a5281c386994f1fbda04df5d2e1f/patches/minecraft/net/minecraft/network/handshake/client/C00Handshake.java.patch#L35

If it's possible, could you please add this feature? I'd really enjoy it. 😊

EmotionalLove commented 4 years ago

I'll take a look, RE_Minecraft should already hide your client brand but if the packet isn't stopped that might get sent to the server. can you confirm that your client brand is exposed to your servers when using ReMinecraft?

douglasb78 commented 4 years ago

RE_Minecraft connects to the server and I can see the lobby chat, however when I connect to the proxy the server disconnects me and displays a custom message.

the client brand is exposed 100%

Mhowser commented 4 years ago

This fabric mod might help https://github.com/liachmodded/brandpacket

EmotionalLove commented 4 years ago

RE_Minecraft connects to the server and I can see the lobby chat, however when I connect to the proxy the server disconnects me and displays a custom message.

the client brand is exposed 100%

gotcha, I'll look into hiding it