EmpaEconversion / aiidalab-aurora

AiiDAlab app for the Aurora BIG-MAP Stakeholder initiative
https://aiidalab-aurora.readthedocs.io/en/latest/
Other
2 stars 5 forks source link

Fixing previously bypasses `mypy` errors #31

Closed edan-bainglass closed 1 year ago

edan-bainglass commented 1 year ago

I have resolved two of three mypy error bypasses:

  1. CyclingParameter.value and CyclingParameter.default_value are now accurately Optional - required redesign of type checking in technique_widget.py
  2. Redundant extra parameter definition in cycling.py models have been removed. Definitions are already present in nested Config classes

The last mypy bypass in query.py requires a more intensive refactoring effort to do away with global variables. This will be addressed in the near future.