search

Empact / roxml

ROXML is a module for binding Ruby classes to XML. It supports custom mapping and bidirectional marshalling between Ruby and XML using annotation-style class methods, via Nokogiri or LibXML.
http://roxml.rubyforge.org/
MIT License
223 stars 176 forks source link

(rebase) Namespace writing - resolves #52 #59

Closed lostapathy closed 6 years ago

lostapathy commented 7 years ago

This rebases #52 to add support for writing namespaces.

Like the original requester I'm open to feedback on this, I just wanted to get that PR updated and ready to either merge, ready for feedback on what else to do, or else reject the whole idea.

lostapathy commented 7 years ago

Good catches - thanks for the review

lostapathy commented 7 years ago

It turns out there was a logical issue in #32 - which caused empty elements without a default to get skipped in the output unless they had a default. I added a failing test of this, confirm that test passed prior to #32, then updated the code added on #32 to make it pass again.

Somehow I made a mess of the commit history, I will try to sort that out so it's cleaner to merge

lostapathy commented 7 years ago

Sorry for the noise - I reset my branch, rebased and reapplied the commits and I think this is ready to look at now.