Fixed the warning of deprecation URI.escape and URI.unescape for Ruby 2.7.x

Empact / roxml

ROXML is a module for binding Ruby classes to XML. It supports custom mapping and bidirectional marshalling between Ruby and XML using annotation-style class methods, via Nokogiri or LibXML.

http://roxml.rubyforge.org/

MIT License

223 stars 176 forks source link

Fixed the warning of deprecation URI.escape and URI.unescape for Ruby 2.7.x #77

Closed ibrahim-saifee closed 3 years ago

ibrahim-saifee commented 3 years ago

Used decode_www_form_component and encode_www_form_component for URL encoding/decoding.

amitminfobeans commented 3 years ago

We can merge this PR as this method removed the warning for me. @Empact Please have a look and merge it. if it looks good.

yld commented 3 years ago

Is there any release plan to include this fix?

anthonyhamou commented 3 years ago

Hello @Empact and also @ibrahim-saifee @amitminfobeans @yld Could you please push an updated gem release to RubyGems that we can then reference in our gemspec ? The latest version of roxml is 4.1.1 from July 6, 2020 https://rubygems.org/gems/roxml Thank you !