search

EmpaticoOrg / scenic-mysql_adapter

MySQL adapter for thoughtbot/scenic
MIT License
30 stars 15 forks source link

Fix conflict with CircleCI config directive #9

Closed dlcmh closed 4 years ago

dlcmh commented 4 years ago

Make mysql2 a development dependency.

Avoids conflict with the - run: echo bundle exec gem uninstall mysql2 directive in .circleci/config.yml.

Error message on CircleCI was:

#!/bin/bash -eo pipefail
bundle exec gem uninstall mysql2

You have requested to uninstall the gem:
    mysql2-0.5.2

scenic-mysql_adapter-1.0.1 depends on mysql2 (>= 0)
If you remove this gem, these dependencies will not be met.
Continue with Uninstall? [yN]
You have requested to uninstall the gem:
    mysql2-0.5.2

scenic-mysql_adapter-1.0.1 depends on mysql2 (>= 0)
If you remove this gem, these dependencies will not be met.
Continue with Uninstall? [yN]
You have requested to uninstall the gem:
    mysql2-0.5.2

scenic-mysql_adapter-1.0.1 depends on mysql2 (>= 0)
If you remove this gem, these dependencies will not be met.
Continue with Uninstall? [yN]  ERROR:  Interrupted
Too long with no output (exceeded 10m0s)
cainlevy commented 4 years ago

I have two concerns with this solution:

1) mysql2 really truly is a dependency 2) the Appraisals setup may depend on correctly specifying a mysql2 version

Sounds like the CircleCI build is broken though? I'll take a look as well.

cainlevy commented 4 years ago

Would you check if this is still an issue? I could not recreate the error you described, but I did update CircleCI to test with Ruby 2.4 and it required dropping test coverage on mysql2-0.4.4.