search

EmperorPinguin / Civ6-mod

An attempt to recreate Civilization VI in Unciv
56 stars 23 forks source link

Correction of all Errors and warnings. #41

Closed BaIthamel closed 1 year ago

BaIthamel commented 1 year ago

I have have hopefully corrected but at least have removed all errors and warning in the current main branch. Listed here:

Bolshoi Theatre's unique "Only available <in cities with a [Theatre Square]> <after adopting [Opera and Ballet]>" contains the conditional "in cities with a [Theatre Square]". This contains the parameter Theatre Square which does not fit parameter type buildingFilter ! Liberalism's unique "[+1 Happiness] [in all cities] <in cities with a [Distric2]>" contains the conditional "in cities with a [Distric2]". This contains the parameter Distric2 which does not fit parameter type buildingFilter ! Magnificence Catherine de Medici's unique "[+2 Culture] from every [Luxury Resource] <with [1] to [6] neighboring [Theatre Square] tiles>" contains parameter Luxury Resource, which does not fit parameter type tileFilter or specialist or buildingFilter ! Magnificence Catherine de Medici's unique "[+2 Culture] from every [Luxury Resource] <with [1] to [6] neighboring [Chateau] tiles>" contains parameter Luxury Resource, which does not fit parameter type tileFilter or specialist or buildingFilter ! Menelik II's unique "[+1 Science, +1 Culture] from every [Rock-Hewn Churh] <with [6] to [6] neighboring [Mountain] tiles>" contains parameter Rock-Hewn Churh, which does not fit parameter type tileFilter or specialist or buildingFilter ! Menelik II's unique "[+1 Science, +1 Culture] from every [Rock-Hewn Churh] <with [5] to [5] neighboring [Mountain] tiles> <with [1] to [1] neighboring [Hill] tiles>" contains parameter Rock-Hewn Churh, which does not fit parameter type tileFilter or specialist or buildingFilter ! Menelik II's unique "[+1 Science, +1 Culture] from every [Rock-Hewn Churh] <with [4] to [4] neighboring [Mountain] tiles> <with [2] to [2] neighboring [Hill] tiles>" contains parameter Rock-Hewn Churh, which does not fit parameter type tileFilter or specialist or buildingFilter ! Menelik II's unique "[+1 Science, +1 Culture] from every [Rock-Hewn Churh] <with [3] to [3] neighboring [Mountain] tiles> <with [3] to [3] neighboring [Hill] tiles>" contains parameter Rock-Hewn Churh, which does not fit parameter type tileFilter or specialist or buildingFilter ! Menelik II's unique "[+1 Science, +1 Culture] from every [Rock-Hewn Churh] <with [2] to [2] neighboring [Mountain] tiles> <with [4] to [4] neighboring [Hill] tiles>" contains parameter Rock-Hewn Churh, which does not fit parameter type tileFilter or specialist or buildingFilter ! Menelik II's unique "[+1 Science, +1 Culture] from every [Rock-Hewn Churh] <with [1] to [1] neighboring [Mountain] tiles> <with [5] to [5] neighboring [Hill] tiles>" contains parameter Rock-Hewn Churh, which does not fit parameter type tileFilter or specialist or buildingFilter ! Menelik II's unique "[+1 Science, +1 Culture] from every [Rock-Hewn Churh] <with [6] to [6] neighboring [Hill] tiles>" contains parameter Rock-Hewn Churh, which does not fit parameter type tileFilter or specialist or buildingFilter ! Religious Idols's unique "[+2 Faith] from every [Gold Ore]" contains parameter Gold Ore, which does not fit parameter type tileFilter or specialist or buildingFilter ! Air Fighter's unique "Only available <in cities with a [Aerodrome]>" contains the conditional "in cities with a [Aerodrome]". This contains the parameter Aerodrome which does not fit parameter type buildingFilter ! Air Bomber's unique "Only available <in cities with a [Aerodrome]>" contains the conditional "in cities with a [Aerodrome]". This contains the parameter Aerodrome which does not fit parameter type buildingFilter ! Buenos Aires's unique "[+1 Happiness] from every [Bonus Resource]" contains parameter Bonus Resource, which does not fit parameter type tileFilter or specialist or buildingFilter ! Cardiff's unique "[+2] [Power] <in cities with a [Harbor]>" contains the conditional "in cities with a [Harbor]". This contains the parameter Harbor which does not fit parameter type buildingFilter ! Mexico City's unique "[+1 Happiness] from every [Enterainment Complex]" contains parameter Enterainment Complex, which does not fit parameter type tileFilter or specialist or buildingFilter ! Singapore's unique "[+1 Production] from every [Trade route]" contains parameter Trade route, which does not fit parameter type tileFilter or specialist or buildingFilter ! Black Queen Catherine de Medici's unique "Free [Spy] appears <upon discovering [Castles]>" contains the conditional "upon discovering [Castles]", which is of an unknown type! Black Queen Catherine de Medici's unique "Provides [1] [Spies] <upon discovering [Castles]>" contains the conditional "upon discovering [Castles]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Horseback Riding]>" contains the conditional "upon discovering [Horseback Riding]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Stirrups]>" contains the conditional "upon discovering [Stirrups]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Gunpowder]>" contains the conditional "upon discovering [Gunpowder]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Military Science]>" contains the conditional "upon discovering [Military Science]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Horseback Riding]>" contains the conditional "upon discovering [Horseback Riding]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Steel]>" contains the conditional "upon discovering [Steel]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Combined Arms]>" contains the conditional "upon discovering [Combined Arms]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Composites]>" contains the conditional "upon discovering [Composites]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Advanced AI]>" contains the conditional "upon discovering [Advanced AI]", which is of an unknown type! Arabia's unique "Free [Great Prophet] appears <upon discovering [Writing]>" contains the conditional "upon discovering [Writing]", which is of an unknown type! Frigate obsoletes at tech Lasers, and therefore Refining for its upgrade Battleship may not yet be researched! De Zeven Provincien obsoletes at tech Lasers, and therefore Refining for its upgrade Battleship may not yet be researched! Jong obsoletes at tech Lasers, and therefore Refining for its upgrade Battleship may not yet be researched! Black Queen Catherine de Medici's unique "Free [Spy] appears <upon discovering [Castles]>" contains the conditional "upon discovering [Castles]", which is of an unknown type! Black Queen Catherine de Medici's unique "Provides [1] [Spies] <upon discovering [Castles]>" contains the conditional "upon discovering [Castles]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Horseback Riding]>" contains the conditional "upon discovering [Horseback Riding]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Stirrups]>" contains the conditional "upon discovering [Stirrups]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Gunpowder]>" contains the conditional "upon discovering [Gunpowder]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Military Science]>" contains the conditional "upon discovering [Military Science]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Horseback Riding]>" contains the conditional "upon discovering [Horseback Riding]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Steel]>" contains the conditional "upon discovering [Steel]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Combined Arms]>" contains the conditional "upon discovering [Combined Arms]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Composites]>" contains the conditional "upon discovering [Composites]", which is of an unknown type! Simon Bolivar's unique "Free [Commandante General] appears <upon discovering [Advanced AI]>" contains the conditional "upon discovering [Advanced AI]", which is of an unknown type! Arabia's unique "Free [Great Prophet] appears <upon discovering [Writing]>" contains the conditional "upon discovering [Writing]", which is of an unknown type!

In the process added this singular warning. No need to add Steel as a prerequisite of Combined Arms - it is already implicit from the other prerequisites! However this implicit requirement is explicitly defined in the official tech tree so I have left it as is.

The vast majority of the errors were due to varying degrees of typos in uniques. This singular exception was Religious Idols's unique "[+2 Faith] from every [Gold Ore]" contains parameter Gold Ore, which does not fit parameter type tileFilter or specialist or buildingFilter ! This is correct as of GS however Gold Ore is a scenario unique resource and does not appear to be implemented. I removed the reference to it.

EmperorPinguin commented 1 year ago

Strange, I didn't get all these warnings on my PC. Thank you.