search

EmpiresCommunity / Unreal-Empires-Project

4 stars 0 forks source link

Ambient sounds continue during end screen #56

Open Trainzack opened 1 year ago

Trainzack commented 1 year ago

It feels wrong to have gully's birdsong play the same time the ending music does.

RoyAwesome commented 1 year ago

We probably need to put these into a sound class, and then mute the sound class at the end of the match.

Trainzack commented 1 year ago

I guess the real question is, do we want any other sounds during the end game? Like if a tank explodes, are we cool with that being silent?

Because if we are, we can probably do something more broad and mute all the sounds other than music.

RoyAwesome commented 1 year ago

So, technically, we can do whatever we want here. We need to define what soundclasses should play during the end screen and which don't.

I currently have things set to "Turn Off" when we go into the endgame screen, so nothing should die, take damage, or explode. I don't think they would generate sounds. Though, if we had like an "End Game Sequence" where the game locks, and all the cameras zoom over to the CV and we witness a cool explosion effect... we'd want that sound to play.

Perhaps the base course of action here is to tag certain sound classes as "This Plays During Endgame" and be mindful of it.