search

EmptyStar / asuna

A Minetest game of vibrant natural wonders
Other
13 stars 4 forks source link

split out asuna_api mod with no dependencies and include it in farming's dependencies #84

Closed programmerjake closed 3 months ago

programmerjake commented 1 year ago

This fixes the error when using moreores caused by farming not declaring asuna_api/asuna_core as dependencies but using their API anyway.

Fixes: #83

EmptyStar commented 1 year ago

Good catch, I must have missed the dependency here. But is there any reason why depends = asuna_core, ... wouldn't work in the farming mod? All of the other mods that depend on Asuna depend on the asuna_core mod which defines all of the relevant metadata and functions that mods should need. I'm hesitant to split up asuna_core any more than absolutely necessary and I'm curious to know your rationale.

programmerjake commented 1 year ago

as explained in the corresponding bug report #83, farming shouldn't depend on asuna_core, because asuna_core depends indirectly on farming when moreores is enabled:

because asuna_core depends on too_many_stones which depends on moreores which depends on farming

this pull request gets around that by making farming depend on asuna_api instead, which is all the parts of asuna_core that can be loaded before any other mod. so the dependency chain through moreores with this PR is: asuna_core depends on too_many_stones depends on moreores depends on farming depends on asuna_api.