search

Empyreal96 / Easy-Fetch-UWP

Formally "Phone Helper": A simple tool to help WP users in downloading various things
16 stars 2 forks source link

Does LangVersion in SharpCompress need to be set to 7.2? #3

Open RoboMWM opened 2 months ago

RoboMWM commented 2 months ago

I'm not sure how this builds without this being set, as Visual Studio will complain about these not being present in 7.0, at least in Visual Studio 2017.

1>------ Build started: Project: StoreLib, Configuration: Debug x64 ------
2>------ Build started: Project: SharpCompress, Configuration: Debug x64 ------
1>Services\FE3Handler.cs(122,33,122,35): warning CS0168: The variable 'ex' is declared but never used
1>Services\FE3Handler.cs(130,33,130,35): warning CS0168: The variable 'ex' is declared but never used
1>Services\FE3Handler.cs(139,34,139,36): warning CS0168: The variable 'ex' is declared but never used
1>Services\DisplayCatalogHandler.cs(204,13,204,20): warning CS0162: Unreachable code detected
1>Services\DisplayCatalogHandler.cs(195,40,195,64): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
1>StoreLib -> D:\robomwm\repos\Easy-Fetch-UWP\StoreLib\bin\x64\Debug\netstandard1.4\StoreLib.dll
1>Successfully created package 'D:\robomwm\repos\Easy-Fetch-UWP\StoreLib\bin\x64\Debug\StoreLib.1.2.1.nupkg'.
1>Done building project "StoreLib.csproj".
3>------ Build started: Project: Easy-Fetch, Configuration: Debug x64 ------
3>C:\Users\robom\.nuget\packages\microsoft.ui.xaml\2.1.190405004\build\Common.targets(15,5): error : Microsoft.UI.Xaml nuget package requires TargetPlatformVersion >= 10.0.17763.0 (current project is 15063)
2>D:\robomwm\repos\Easy-Fetch-UWP\SharpCompressUWP\Archives\AbstractWritableArchive.cs(99,67,99,74): error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater.
2>D:\robomwm\repos\Easy-Fetch-UWP\SharpCompressUWP\Archives\AbstractWritableArchive.cs(110,67,110,74): error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater.
2>D:\robomwm\repos\Easy-Fetch-UWP\SharpCompressUWP\Archives\IWritableArchive.cs(11,112,11,119): error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater.
2>D:\robomwm\repos\Easy-Fetch-UWP\SharpCompressUWP\Common\SevenZip\CMethodId.cs(3,14,3,22): error CS8107: Feature 'readonly structs' is not available in C# 7.0. Please use language version 7.2 or greater.
========== Build: 1 succeeded, 2 failed, 0 up-to-date, 0 skipped ==========
RoboMWM commented 2 months ago

Or perhaps this LangVersion is implied when targeting 19041, hmm.

RoboMWM commented 2 months ago

Just realized I can't add 19041 to VS 2017. But I don't think 14393 is in VS 2019... or is it? I can install to check... even more interested in what you used to build this lol.

Update: checked vs2019 installer, ok I'm assuming at some point you started using VS 2019 as 19041 is default sdk for UWP apps in that version. Also realized you don't need to have sdk of minimum version installed, I guess that only applies for new projects when trying to set the minimum version dropdown. I guess if my memory servers correct, VS 2017 is the only version that can deploy and debug on Windows 10 Mobile.

RoboMWM commented 2 months ago

Or perhaps this LangVersion is implied when targeting 19041, hmm.

Yup, this is the reason why. Either that or Visual Studio 2019 defaults to that.