search

EmranMR / tree-sitter-blade

tree-sitter grammar for Laravel blade files
MIT License
186 stars 8 forks source link

fix: set @else itself as a directive #17

Closed yaegassy closed 1 year ago

yaegassy commented 1 year ago

Hi, I adjusted the @else itself as it is not recognized as a directive.

As a side note, I didn't include files under src/* in the pull request, so please generate and try it on your own.

Before:

1_tree-sitter-blade-before

After:

2_tree-sitter-blade-after
calebdw commented 1 year ago

@yaegassy

As a side note, I didn't include files under src/* in the pull request, so please generate and try it on your own.

You should PR complete changes, that includes the generated files.

yaegassy commented 1 year ago

@CalebDW Does the src/* generated on my machine work fine on other machines?

yaegassy commented 1 year ago

@CalebDW Done.

EmranMR commented 1 year ago

Hi @yaegassy ! Good catch and thanks for the pull request.😊

Yes, the generated tree-sitter files are pretty much universal. Some editors/services may need the generated files to then be recompiled to dynamic library but wouldn't apply to this repo. They will prob use the files in src as their base and use various tools to change it over.