search

EmranMR / tree-sitter-blade

tree-sitter grammar for Laravel blade files
MIT License
186 stars 8 forks source link

little issue with sintax color #26

Closed juancarlosso closed 1 year ago

juancarlosso commented 1 year ago

Works fine, but i am having this issue Screenshot The color sintax looks all white, i am using the "Dark theme" (originally nova) Is this normal or something i am not doing well ?

Thanks and keep the good work! 👍

EmranMR commented 1 year ago

Hi @juancarlosso, This is an issue with the tree-sitter-php

Thankfully @CalebDW has already done the work and we are all patiently awaiting for his pull request to be merged by the tree-sitter-php core team 😬. Once they merge, we should be good to go.

There is only one problem for us, and that is the fact Nova provides the php syntax support as a first party, and then we have to wait for them to update their tree-sitter-php parser... As a result I am going to see if I can clone the adjusted tree-sitter-php and override the ones provided by the Nova itself this weekend or so. Will be fun to see Nova blowing up 💥 because of conflicts and etc, considering there is no way for us to disable the built-in extensions... 😂

EmranMR commented 1 year ago

Hi @juancarlosso I would suggest upgrading your Nova extension to V1.0.0 which was released today 👀

juancarlosso commented 1 year ago

Excellent ! Thanks