search

EmranMR / tree-sitter-blade

tree-sitter grammar for Laravel blade files
MIT License
186 stars 8 forks source link

Comment fix #45

Closed calebdw closed 10 months ago

calebdw commented 10 months ago

Fixes #44

I also moved the tests to be more consistent with other repos.

EmranMR commented 10 months ago

@calebdw Thank you for the pull request! Regarding the comment you are right! text node is redundant, and your implementation makes more sense (also reduces noise)! Also thanks for moving tests so it follows the consensus, I just went ahead with tree-sitter docs and randomly picked one from "corpus or test/corpus".

calebdw commented 10 months ago

@EmranMR, being under test is usually more common because you can have highlight tests under test/hightlight and it keeps all the tests grouped together