EmreSarikaynak / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Disable InPreview for templates with no coordinates #623

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Our extension is suppose to simply not show the highlighter if the template is 
one of the old non re-processed templates. This is in order to avoid miss 
coordination of the highlighter shapes.
I activated the interactive personalization feature on this (old) template:
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/subcategory-02/dl
-envelope-with-clear-addr-window.html

There's that red dot that appears on hover now. Meaning the highlighter is 
activated just doesn't have to proper coordinates.

Original issue reported on code.google.com by agur...@gmail.com on 8 Aug 2011 at 4:07

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 8 Aug 2011 at 9:54

GoogleCodeExporter commented 9 years ago
Differentiate by the XML contents

Old: 
http://order.uprintinvitations.com/?page=template-xml;TemplateID=0EFAA377-A7D1-4
3D1-91E0-F864EDFBDB73

New: 
http://orders.printoexpress.co.uk/?page=template-xml;TemplateID=825D8D56-3214-4B
92-927C-609354713F5B

Old one has 
<Page Name="Page 1" 
PreviewImage="preview/1e349b90-add2-4856-bedd-a90d5cb822f7-0.jpg" 
ThumbImage="thumb/1e349b90-add2-4856-bedd-a90d5cb822f7-0.jpg" Page2BoxX="" 
Page2BoxY="" Page2BoxW="" Page2BoxH="">

with Page2BoxX="" Page2BoxY="" Page2BoxW="" Page2BoxH=""

and let's get a stable out once it's tested.

Original comment by ad...@zetaprints.com on 10 Aug 2011 at 10:29

GoogleCodeExporter commented 9 years ago
Diff: http://code.google.com/p/magento-w2p/source/detail?r=1769

Original comment by Anatoly....@gmail.com on 11 Aug 2011 at 9:41

GoogleCodeExporter commented 9 years ago
Please, test it with 1.9.1.0alpha17 release.

Original comment by Anatoly....@gmail.com on 15 Aug 2011 at 1:45

GoogleCodeExporter commented 9 years ago
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha18 (alpha)

Highlighter is still active (unprocessed_temp.png)
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/dl-envelope-with-
clear-addr-window.html

Original comment by agur...@gmail.com on 16 Aug 2011 at 2:03

Attachments:

GoogleCodeExporter commented 9 years ago
Do we have PHP caching on d1?

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 7:39

GoogleCodeExporter commented 9 years ago
I've reset PHP cache by reloading web-server.
Please, re-test it.

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 7:45

GoogleCodeExporter commented 9 years ago
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha19 (alpha)

I reprocessed this template in the portal end:
http://cname.zetaprints.com/?page=template;TemplateID=9B8BB2CC-6036-4664-A6B6-99
12BDCFB4FA
it is for this product:
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/business-card.htm
l

Now it just seems as if InPrev is disabled for the category. I enabled it for 
the category and for the template it self and the highlighter doesn't show. It 
should show since now, unlike the other templates in that category, this one 
should have the correct shape coordinates since it is reprocessed.

Original comment by agur...@gmail.com on 17 Aug 2011 at 4:31

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
It seems smth wrong was happened on ZP side.

From template details:
 * Page2BoxX, Page2BoxY, Page2BoxW and Page2BoxH attributes don't have values.
 * All shapes has very similar coordinates and are positioned near the centre.

Original comment by Anatoly....@gmail.com on 18 Aug 2011 at 12:02

GoogleCodeExporter commented 9 years ago
I think this is one of those transitional templates with crook coordinates.
We should probably filter them.
Can you use some other old template with no coordinates at all?

Original comment by ad...@zetaprints.com on 18 Aug 2011 at 12:31

GoogleCodeExporter commented 9 years ago
OK, you lost me.

We have 3 types of template XML:
1. Old, with no coordinates at all
2. New, with correct coordinates
3. Crook, with incorrect coordinates

The template above is in [3]. We need to look into this, but it shouldn't be a 
show stopper. 

Inreview should handle [1] & [3] as if there are no coordinates.
Only [2] should actually get in-preview editing.

You can find old templates in demo.zetaprints.com or I can dig something out.
Hope it makes sense.

Original comment by ad...@zetaprints.com on 18 Aug 2011 at 12:42

GoogleCodeExporter commented 9 years ago
Yep, works as intended then.
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha19 (alpha)

The template I re-processed before:
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/subcategory-01/bu
siness-card.html
must have been one of those that fall under "3. Crook, with incorrect 
coordinates"

I tried it on another template:
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/subcategory-01/wa
termark-template-file.html
it showed no overlay shapes. I went back to the portal side, re-processed it 
and refreshed the Magento page. Voila, the highlighter got activated.

Original comment by agur...@gmail.com on 18 Aug 2011 at 2:19

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 5 Sep 2011 at 5:01

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 16 Sep 2011 at 12:05