EmuDeck / emudeck-we

Windows Edition
GNU General Public License v3.0
42 stars 20 forks source link

emulator not found when opening pcsx2 in standalone emulationstation-de #1

Closed subtrusion closed 1 year ago

subtrusion commented 1 year ago

hey emudeck team,

was playing with pcsx2 and opening via emulationstation-de instead of direct through steam and noticed an emulator not found error. looks like the command in the systems config and the paths to the emulator are a little off. i'm not sure where in the setup script the break takes place, but if it helps my fix to the installed configurations are below:

  1. the qt version of pcsx2 uses "-nogui" instead of "--nogui" https://wiki.pcsx2.net/index.php/Command-line_support file: INSTALL-DRIVE:\Emulation\tools\EmulationStation-DE\resources\systems\windows\es_systems.xml line: 972 %EMULATOR_PCSX2% --nogui -nogui -fastboot -fullscreen %ROM%

  2. The executable points to the non-qt version of pcsx2, but the qt version is installed file: INSTALL-DRIVE:\Emulation\tools\EmulationStation-DE\resources\systems\windows\es_find_rules.xml line: 125 %ESPATH%\PCSX2\ pcsx2.exe pcsx2-qtx64-avx2.exe line: 126 %ESPATH%\Emulators\PCSX2\ pcsx2.exe pcsx2-qtx64-avx2.exe line: 127 %ESPATH%..\PCSX2\ pcsx2.exe pcsx2-qtx64-avx2.exe

hope this helps

Godsbane commented 1 year ago

Is the alternate emulator set correctly?

One is for wx and one is for qt

subtrusion commented 1 year ago

it looks like my install only had pcsx2-qt64-avx2.exe (no pcsx2.exe in \Emulation\tools\EmulationStation-DE\Emulators\PCSX2). just from a quick look at \EmuDeck\backend\functions\EmuScripts\emuDeckPCSX2.ps1 the wx version is not included

my guess is the download url used in vars.ps1 doesn't include wx: https://github.com/dragoonDorise/rpcsx2win/releases/download/1.0/pcsx2.7z

Godsbane commented 1 year ago

Right I meant in es-de, there's an alternate emulator setting. Just curious what it was set to.

dragoonDorise commented 1 year ago

Hi @subtrusion, we've reported this to the EmulationStation team! thanks for opening the issue.

In the meantime we've published a fix so reinstalling / updating should fix it

leonstyhre commented 1 year ago

I'm not sure I understand the problem, these are the es_find_rules.xml entries for PCSX2:

   <emulator name="PCSX2">
        <!-- Sony PlayStation 2 emulator PCSX2 -->
        <rule type="staticpath">
            <entry>%ESPATH%\Emulators\PCSX2-Qt\pcsx2-qtx64*.exe</entry>
            <entry>%ESPATH%\PCSX2-Qt\pcsx2-qtx64*.exe</entry>
            <entry>%ESPATH%\..\PCSX2-Qt\pcsx2-qtx64*.exe</entry>
        </rule>
    </emulator>
    <emulator name="PCSX2-LEGACY">
        <!-- Sony PlayStation 2 emulator PCSX2 (legacy) -->
        <rule type="staticpath">
            <entry>%ESPATH%\Emulators\PCSX2\pcsx2.exe</entry>
            <entry>%ESPATH%\PCSX2\pcsx2.exe</entry>
            <entry>%ESPATH%\..\PCSX2\pcsx2.exe</entry>
        </rule>
    </emulator>

And this is the ps2 entry in es_systems.xml:

    <system>
        <name>ps2</name>
        <fullname>Sony PlayStation 2</fullname>
        <path>%ROMPATH%\ps2</path>
        <extension>.bin .BIN .chd .CHD .ciso .CISO .cso .CSO .dump .DUMP .elf .ELF .gz .GZ .m3u .M3U .mdf .MDF .img .IMG .iso .ISO .isz .ISZ .ngr .NRG</extension>
        <command label="PCSX2">%EMULATOR_RETROARCH% -L %CORE_RETROARCH%\pcsx2_libretro.dll %ROM%</command>
        <command label="PCSX2 (Standalone)">%EMULATOR_PCSX2% -batch %ROM%</command>
        <command label="PCSX2 Legacy (Standalone)">%EMULATOR_PCSX2-LEGACY% --nogui %ROM%</command>
        <command label="Play! (Standalone)">%EMULATOR_PLAY!% --disc %ROM%</command>
        <platform>ps2</platform>
        <theme>ps2</theme>
    </system>

There is no -nogui or --nogui flag set for the Qt release of PCSX2.