EmuKit / emukit

A Python-based toolbox of various methods in decision making, uncertainty quantification and statistical emulation: multi-fidelity, experimental design, Bayesian optimisation, Bayesian quadrature, etc.

https://emukit.github.io/emukit/

Apache License 2.0

605 stars 128 forks source link

fix bug in interface of single_objective_bayesian_optimisation example #221

Closed DavidJanz closed 5 years ago

DavidJanz commented 5 years ago

Description of changes:

single_objective_bayesian_optimisation.py, used within the tutorial examples, seems to have a call to an attribute that no longer exists (perhaps part of old interface?). Removing that call appears to lead to the desired behaviour.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io commented 5 years ago

Codecov Report

Merging #221 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         109      109           
  Lines        3025     3025           
  Branches      308      308           
=======================================
  Hits         2702     2702           
  Misses        265      265           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7421cb7...ce5d180. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #221 into master will decrease coverage by 0.09%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #221     +/-   ##
=========================================
- Coverage   89.32%   89.22%   -0.1%     
=========================================
  Files         109      109             
  Lines        3025     3025             
  Branches      308      308             
=========================================
- Hits         2702     2699      -3     
- Misses        265      267      +2     
- Partials       58       59      +1

Impacted Files	Coverage Δ
emukit/core/optimization/optimizer.py	`77.02% <0%> (-4.06%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7421cb7...cda6a36. Read the comment docs.

DavidJanz commented 5 years ago

@apaleyes done