search

EmuKit / emukit

A Python-based toolbox of various methods in decision making, uncertainty quantification and statistical emulation: multi-fidelity, experimental design, Bayesian optimisation, Bayesian quadrature, etc.
https://emukit.github.io/emukit/
Apache License 2.0
605 stars 128 forks source link

minor bug fix #263

Closed mmahsereci closed 5 years ago

mmahsereci commented 5 years ago

Issue #, if available:

Description of changes: removing outdated and obsolete quantity 'integral_parameters' in warped gp & removing corresponding test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

apaleyes commented 5 years ago

Can you please fix the failing build? An integration test still refers to the deleted property

codecov-io commented 5 years ago

Codecov Report

Merging #263 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   90.08%   90.07%   -0.02%     
==========================================
  Files         114      114              
  Lines        3670     3666       -4     
  Branches      413      413              
==========================================
- Hits         3306     3302       -4     
- Misses        283      285       +2     
+ Partials       81       79       -2
Impacted Files Coverage Δ
emukit/quadrature/methods/warped_bq_model.py 82.05% <100%> (-1.67%) :arrow_down:
emukit/test_functions/forrester.py 77.27% <0%> (ø) :arrow_up:
emukit/test_functions/non_linear_sin.py 72.72% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2da4944...5f9247e. Read the comment docs.

mmahsereci commented 5 years ago

I replaced the reference in the tutorial notebook with the correct one.