Closed apaleyes closed 4 years ago
Check out this pull request on
You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.
Merging #283 into master will decrease coverage by
<.01%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 89.78% 89.77% -0.01%
==========================================
Files 118 119 +1
Lines 3818 3835 +17
Branches 427 427
==========================================
+ Hits 3428 3443 +15
- Misses 309 311 +2
Partials 81 81
Impacted Files | Coverage Δ | |
---|---|---|
emukit/core/initial_designs/base.py | 85.71% <ø> (ø) |
:arrow_up: |
emukit/core/initial_designs/__init__.py | 100% <ø> (ø) |
:arrow_up: |
emukit/core/initial_designs/random_design.py | 100% <ø> (ø) |
:arrow_up: |
emukit/core/initial_designs/latin_design.py | 90% <ø> (ø) |
:arrow_up: |
emukit/core/initial_designs/sobol_design.py | 88.88% <88.88%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f9284cc...ee88af1. Read the comment docs.
Thanks! You would it need to push this now though, I can't do it anymore
Issue #, if available: #278
Description of changes: Follow up on #280 . Fixed issues with optional dependencies for Latin and Sobol designs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.