Closed esiivola closed 4 years ago
Hi! Thanks for the fast reply! Yes, I can make a dependency installation instead, no problem!
Ok, so we have some code in here which is under MIT license, and some under BSD. My understanding is that if you copy such code, you need to include corresponding licenses, and I doubt we can do that with emukit.
But it is ok to use software under these licenses. Can the implementation be done with dependency installation instead?
Hi! This is done now. I moved the black box functions to a separate git repo and also added a dependency for stan_utility.
Merging #285 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 119 119
Lines 3839 3839
Branches 429 429
=======================================
Hits 3447 3447
Misses 311 311
Partials 81 81
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d726691...db84f2f. Read the comment docs.
Issue #, if available:
Description of changes: Added an example for performing the experiments in https://arxiv.org/abs/2003.11435
See /emukit/examples/preferential_batch_bayesian_optimization/README.md for details.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.