Tracking points in outer loop

EmuKit / emukit

A Python-based toolbox of various methods in decision making, uncertainty quantification and statistical emulation: multi-fidelity, experimental design, Bayesian optimisation, Bayesian quadrature, etc.

https://emukit.github.io/emukit/

Apache License 2.0

605 stars 128 forks source link

Tracking points in outer loop #308

Closed charelstoncrabb closed 4 years ago

charelstoncrabb commented 4 years ago

Currently the next candidate points are tracked only via logging output--tracking this as a data member would be much more useful.

I would be happy to submit a (2-line) PR, how might I push a branch?

apaleyes commented 4 years ago

you would need to fork emukit and submit a PR from there. Refer to, for example, this guide: https://gist.github.com/Chaser324/ce0505fbed06b947d962

apaleyes commented 4 years ago

@mmahsereci made a good observation in the PR, noting that this data is already stored in the loop state. I haven't read the actual feature description closely enough the first time to realize that. Is that indeed sufficient for your needs @charelstoncrabb ?

mmahsereci commented 4 years ago

I am closing this issue for now as the feature requested seems to be implemented already. @charelstoncrabb , feel free to open an issue again in case you have further questions. Thanks!