EmuKit / emukit

A Python-based toolbox of various methods in decision making, uncertainty quantification and statistical emulation: multi-fidelity, experimental design, Bayesian optimisation, Bayesian quadrature, etc.

https://emukit.github.io/emukit/

Apache License 2.0

605 stars 128 forks source link

Fix scipy again #433

Closed apaleyes closed 2 years ago

apaleyes commented 2 years ago

Issue #, if available: #421

Description of changes: Scipy minimize expects 1d inputs, and we were passing 2d for some unclear reason. Best part is that we were doing it intentionally, for no other reason, so the fix is just to remove a few symbols. Nice!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 2 years ago

Codecov Report

Merging #433 (4288b38) into main (7218ac9) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   89.15%   89.15%           
=======================================
  Files         136      136           
  Lines        4703     4703           
  Branches      681      681           
=======================================
  Hits         4193     4193           
  Misses        393      393           
  Partials      117      117

Impacted Files	Coverage Δ
...sian_optimization/local_penalization_calculator.py	`86.66% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mmahsereci commented 2 years ago

Nice, thanks! So weird, the bug seems to have been there since the begging.

apaleyes commented 2 years ago

There is a warning about it in scipy that promises "i'll turn into an error after 1.11.0, fix me!". Well, 8 releases later it finally delivered on that promise. Could be that we ignored it all that time