search

EmulatorArchive / jpcsp

Automatically exported from code.google.com/p/jpcsp
1 stars 0 forks source link

Failed validation prevents shaders from working on some AMD cards #312

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Fragment shader validation fails on AMD Radeon HD3870x2 (latest 12.6 legacy 
drivers on Linux x64), even with dynamic shader generation enabled, which 
forces JPCSP not to use shaders in any game.

I tried changing "return linked && validated;" to just "return linked;" in 
linkShaderProgram(), and shaders actually work properly in a few games I tested 
(Sonic Rivals 1/2, BlazBlue: Continuum Shift II).

A quick and dirty fix would be to ignore shader validation results and use them 
anyway if linking was successful, or to add an option to do so if it breaks 
anything.

Relevant messages from the log file:
1470 [GUI] ERROR ge - Shader error log: Vertex shader was successfully compiled 
to run on hardware.
Fragment shader was successfully compiled to run on hardware.
Vertex shader(s) linked, fragment shader(s) linked.
Validation failed! - Different sampler types for same sample texture unit in 
fragment shader.

1471 [GUI] WARN  ge - Shaders do not run correctly on your computer. They have 
been automatically disabled.

Original issue reported on code.google.com by Nekit1000 on 9 Aug 2012 at 12:56

GoogleCodeExporter commented 9 years ago 
Trying to fix this issue in r2674 and r2677.

Original comment by gi...@web.de on 9 Aug 2012 at 4:31

GoogleCodeExporter commented 9 years ago 
Another try in r2684. Does it help?

Original comment by gi...@web.de on 10 Aug 2012 at 6:38

GoogleCodeExporter commented 9 years ago 
Seems to work properly without any shader-related errors/warnings now.

Original comment by Nekit1000 on 10 Aug 2012 at 8:48

GoogleCodeExporter commented 9 years ago 
Sounds great! :-)
Waiting for test result of montcer9012:
http://www.emunewz.net/forum/showthread.php?tid=3056&pid=104235#pid104235

Original comment by gi...@web.de on 10 Aug 2012 at 9:12

GoogleCodeExporter commented 9 years ago 
Successful test confirmed by montcer9012 as well:
http://www.emunewz.net/forum/showthread.php?tid=3056&pid=104278#pid104278

Original comment by gi...@web.de on 11 Aug 2012 at 6:29