Closed GoogleCodeExporter closed 9 years ago
I don't like the idea to have to use a command-line switch for changing the UI
language.
The language switch should stay as a menu option.
Original comment by gi...@web.de
on 14 Jun 2013 at 7:36
What about a trade-off? :)
By default the user's locale is to be used. But the user is able to select the
language of his choice from the menu and after restarting JPCSP the selected
language would override the locale.
I would not prefer to switch language at runtime, at it needs more
consideration than starting fresh. Also I don't think user switch languages
frequently, so this would be a minor annoyance.
Original comment by tempura....@gmail.com
on 16 Jun 2013 at 9:42
Where is the restriction coming from? Are classes from NetBeans to be included
in the project?
It's OK to have to restart Jpcsp to enable the new language, but the language
has to be stored in the Settings.properties and users should not have to modify
startup scripts (e.g. to add command line switches).
A lot of users are often updating the Jpcsp version to test new releases. They
simply copy the Settings.properties to the new version. This should also work
for the language.
Original comment by gi...@web.de
on 17 Jun 2013 at 10:41
It's not about NetBeans but Swing. For the language change at runtime each
widget needs to have setText() called again.
ATM the UI is built again for the MainWindow - which results in no proper
display (at least for me when I switch to German the buttons revert to
English). Restarting ensures that the UI is properly displayed and resized for
the translated strings to fit.
With the trade-off I have mentioned no command line option is necessary as the
language setting is still stored in Settings.properties.
Users can overrule the system language via menu if they wish not to use their
system locale - but I believe, that this will only be a small fraction. :)
Original comment by tempura....@gmail.com
on 17 Jun 2013 at 5:36
I have commited the changed in r3625. Please report any regressions here.
Original comment by tempura....@gmail.com
on 29 Jun 2013 at 12:43
So far there seem to be no more regressions, so I will close this issue.
With r3300 all locale codes have been corrected and untranslated strings added
to the .properties files.
So feel free to update them and send them back to improve the translation.
Thanks!
Original comment by tempura....@gmail.com
on 6 Jul 2013 at 7:28
Original issue reported on code.google.com by
tempura....@gmail.com
on 10 Jun 2013 at 8:08Attachments: