Some hacked rom images don't display properly.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Load a color hacked Gameboy rom.
2. Load a GBA rom with an injected NES rom.
3. May or may not affect GBA/GBC homebrew titles.  Not enough material to 
fully verify.

-What is the expected output? What do you see instead?
See this capture for reference.  http://www.youtube.com/watch?v=V-MoNh4lbhI
Color patched Gameboy titles don't display properly.  Tiles all legit, but 
color assignment is off.  PocketNES injected GBA roms suffer from 
unreadable text and diminished graphic quality.  This is likely due to the 
necessity for intended flickering required to compensate for the rescaling 
of NES titles.  V1.0.1 renders both the aforementioned types flawlessly (as 
does a GBASP with a GBA Supercard, just to confirm the roms are compatible 
with the original hardware).

-Does this issue occur on VBA-M?
Yes, but I think it's relevant to post here as these issues did not present 
themselves until the v1.0.2 VBA-M code merge.  Might help determine the 
source of the problem.  I'll also post this on their forum.

-What version of the product are you using? On GameCube or Wii?
Tested working on Wii v1.0.1 and broken on Wii v1.0.2-7 (although the 
gameboy color issue was not, I believe, present until v1.0.4).

Please provide any additional information below.
see http://metroid.homestead.com/Metroid2DX.html
and http://www.pocketnes.org/ for more info if needed.

Original issue reported on code.google.com by trevorqu...@gmail.com on 2 Mar 2009 at 8:34

[GoogleCodeExporter]

Update:
Can't post on the VBA-M forum.  It's currently down.  Will try again later.

Original comment by trevorqu...@gmail.com on 2 Mar 2009 at 8:45

[GoogleCodeExporter]

The VBA-M project has moved to vba-m.com. The forums are also there.

Original comment by dborth@gmail.com on 2 Mar 2009 at 9:01

[GoogleCodeExporter]

Will do.  Thank you.

Original comment by trevorqu...@gmail.com on 2 Mar 2009 at 9:48

[GoogleCodeExporter]

Unable to create an account on their forums and can't get anyone to push the 
activation through as of yet.  Lame.  Keep getting an SQL error.  If anyone 
already 
has an account there, I'd appreciate it if you'd relay the info.

Original comment by trevorqu...@gmail.com on 5 Mar 2009 at 5:28

[GoogleCodeExporter]

:( Seems like they're having problems again.

Original comment by dborth@gmail.com on 5 Mar 2009 at 5:43

[GoogleCodeExporter]

I couldn't get Metroid 2 DX to display like that on the Wii, I just got a white 
screen. It displayed like you showed on VBA-M.

Original comment by Carl.Kenner@gmail.com on 8 Mar 2009 at 4:09

[GoogleCodeExporter]

I've narrowed down the problem (with Metroid 2 DX at least) to revision r61. 
Unfortunately r61 makes many large changes, so I'll need to examine it some 
more.

Original comment by Carl.Kenner@gmail.com on 11 Mar 2009 at 7:00

[GoogleCodeExporter]

Original comment by Carl.Kenner@gmail.com on 11 Mar 2009 at 7:02

• Changed state: Started

[GoogleCodeExporter]

Awesome!  I had looked at the source, but I'm all thumbs when it comes to code. 
 I 
get it, but I can't get very far with it.  I usually end up breaking more than 
I fix.

Original comment by trevorqu...@gmail.com on 11 Mar 2009 at 2:06

[GoogleCodeExporter]

The problem seems to be in GB.cpp, in the gbWriteMemory function and the 
gbEmulate 
function. I'm slowing going through the process of applying all the changes in 
r61 to 
r60 while making sure not to break Metroid 2 DX. I've done everything except 
half the  
(long and complicated) gbEmulate function. Then I have to see if I can apply 
those 
changes to the current version of GB.cpp. I tried just fixing the gbWriteMemory 
function in the current version, but it only partly fixed it.

Original comment by Carl.Kenner@gmail.com on 11 Mar 2009 at 3:55

[GoogleCodeExporter]

I'm not sure if this will help you, but I know that for most color hacked roms, 
the 
color data is stored at the end of the rom file where there would normally be 
zero 
values or, in the case of Metroid 2, special effects used for things such as 
screen 
transitions.
"The fading effect between some level areas is missing, replaced by
temporary tile distortion."
Here's another file you could use as a comparison:
http://www.romhacking.net/hacks/92/

Original comment by trevorqu...@gmail.com on 11 Mar 2009 at 4:53

[GoogleCodeExporter]

Original comment by Carl.Kenner@gmail.com on 11 Mar 2009 at 10:37

• Changed state: Fixed

[GoogleCodeExporter]

Good deal!  Any leads on the Pocketnes flicker issue?  I think this probably 
only 
applies to 'tards like me who think it matters to play as many games as 
possible in 
the same series on the same console (or, in this case, emulator), but for what 
it's 
worth, I don't think it would be a difficult fix as the issue only came up when 
the 
"flicker reduction" was applied in 1.0.4.

Original comment by trevorqu...@gmail.com on 12 Mar 2009 at 5:38

[GoogleCodeExporter]

I don't know, you tell me. I haven't tested pocketnes yet. But if the issue 
only 
showed up in 1.0.4, it might be fixed or it might not, because I undid some of 
the 
1.0.4 changes. 

Original comment by Carl.Kenner@gmail.com on 12 Mar 2009 at 6:53

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Sorry, I just tested it, and poketnes still flickers. So it is a separate issue 
unrelated to this issue.

Which should have been obvious to me if I had used my brain, since poketnes is 
for 
the Gameboy Advance, and this is a Gameboy Colour issue. The two have little 
code in 
common.

I can't be bothered to fix emulation of an emulator right now, when there is 
already 
an NES emulator for the Wii. However, this also seems to affect some actual GBA 
ROMs 
in the Classic NES series. 

I think you should post a separate issue.

Original comment by Carl.Kenner@gmail.com on 12 Mar 2009 at 7:47

[GoogleCodeExporter]

Sure thing.  Will do.  Like I said, it's probably an issue that only really 
bothers a 
select few of us, but I thought it might be worth a look.  I'll see about maybe 
re-
editing the video I posted to Youtube (or not, don't know if i can afford the 
time).  
Either way, I'll repost that issue soon and comment that it may or may not be 
related 
to the classic nes series rom issue.

Original comment by trevorqu...@gmail.com on 12 Mar 2009 at 6:35

[GoogleCodeExporter]

Oops... This fix breaks lots of monochrome gameboy games. Looks like it needs 
more 
work...

Original comment by Carl.Kenner@gmail.com on 20 Mar 2009 at 8:17

• Changed state: Started
• Added labels: Priority-Critical
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Original comment by Carl.Kenner@gmail.com on 10 Apr 2009 at 1:25

• Added labels: Priority-Medium
• Removed labels: Priority-Critical

[GoogleCodeExporter]

We'll fix it eventually, but it's VBA-M's fault, and we can't do anything 
without the 
danger of wrecking lots of other games.

Original comment by Carl.Kenner@gmail.com on 27 May 2009 at 6:06

• Changed state: WontFix

[GoogleCodeExporter]

get your facts right before throwing blame around.

Original comment by danialho...@gmail.com on 26 Sep 2011 at 3:54

[GoogleCodeExporter]

Check your time stamps, asshole.  To my knowledge, this was never fixed, but 
even if it was, this hasn't been discussed in over two years, which makes it 
now completely irrelevant.  Pay more attention before slinging mud over a 
now-ancient topic, prick.

Original comment by trevorqu...@gmail.com on 26 Sep 2011 at 10:44