`RewardAddress`, `BaseAddress`, `EnterpriseAddress`, `PointerAddress` have no getter for network id

Emurgo / cardano-serialization-lib

This is a library, written in Rust, for serialization & deserialization of data structures used in Cardano's Haskell implementation of Alonzo along with useful utility functions.

Other

236 stars 125 forks source link

`RewardAddress`, `BaseAddress`, `EnterpriseAddress`, `PointerAddress` have no getter for network id #660

Closed klntsky closed 3 months ago

klntsky commented 10 months ago

Address type does have it, but it is not convenient to convert every time a network id is needed.

lisicky commented 10 months ago

Hi @klntsky! Hm we can add it in the next version : )

gitmachtl commented 10 months ago

wasn't the PointerAddresssupposed to 'die', because noone ever used it? should it than being removed from the lib?

lisicky commented 10 months ago

@gitmachtl if it will be removed from the next CDDL we can deprecate PointerAddress in the CSL API. But as I see it still exists in the conway CDDL https://github.com/IntersectMBO/cardano-ledger/blob/5f76eb918c16645ed98a7fbab513c2d549837ed5/eras/conway/impl/cddl-files/conway.cddl#L264-L265

lisicky commented 3 months ago

the lates CSL 12 should have it