Fee calculation mismatch with conway certificates

Emurgo / cardano-serialization-lib

This is a library, written in Rust, for serialization & deserialization of data structures used in Cardano's Haskell implementation of Alonzo along with useful utility functions.

Other

230 stars 124 forks source link

Fee calculation mismatch with conway certificates #663

Closed Scitz0 closed 6 months ago

Scitz0 commented 6 months ago

Hi,

I have noticed while developing against latest CSL 12 alpha-15 that fee calculation when including both drep registration and drep delegation is 4224 lovelace short. So it seems that CSL is currently unable to determine that the drep vkey witness is needed based on provided certificates.

I also tried it against the bleeding edge evgenii/conway_certs e835403ef1b6714cf8ddbdb407fa66478907335f commit with no change.

@lisicky as you seem to be developing many of the changes against the conway era, is this a known issue?

Ryun1 commented 6 months ago

Is it because Alpha 15 is preparing for Node 8.8, where DRep registrations WILL require an extra witness when compared to current node version?

lisicky commented 6 months ago

Hi @Scitz0 ! Thanks for your issue, yes we know about and will be fixed in the next version, from my estimation it will be in the next week. For drep registration you need to provide a witness only from node 8.8

lisicky commented 6 months ago

@Ryun1 for node 8.8 it will be CSL 12 alpha 16

Scitz0 commented 6 months ago

Ok thanks for input :+1: