Emurgo / project-icarus-importer

Icarus, a reference implementation for a lightweight wallet developed by the IOHK Engineering Team.
Other
4 stars 2 forks source link

new db column for the storage of a full address #8

Open nicarq opened 5 years ago

nicarq commented 5 years ago

After https://github.com/Emurgo/project-icarus-importer/pull/4 we are limiting the addresses storage to a maximum of 2k. No matter what is going to be the ”final” size of the address, probably we want to store it anyways.

We should create a new column (non-indexable) that stores any size address. I think this information is going to come handy in the near-future.

Question: should we store the full address for all the addresses or for only the ones that go over the limit?

vsubhuman commented 5 years ago

should we store the full address for all the addresses or for only the ones that go over the limit

If not create a separate table just for these cases - then I would definitely argue for storing full versions only for these long addresses.

But I would think of creating a separate table like (short_address text, full_address text), and the first one may be indexed.