search

Emurgo / yoroi-frontend

Yoroi Wallet - Cardano ADA Wallet - Your gateway to the financial world (extension frontend)
https://yoroi-wallet.com/
MIT License
340 stars 103 forks source link

[ERG] Support for Mnemonic Password when restoring Ergo wallets #2177

Open mailman451 opened 3 years ago

mailman451 commented 3 years ago

Back in the day I created my Ergo wallet by setting up a full node using the java client. At that time I thought it was a good idea to use the mnemonic password, without realising that probably no third-party software will support it.

I know I can create a new wallet with a new address and transfer the old wallet, but I wanted to ask first if there may be a chance that Yoroi might consider supporting a mnemonic password when restoring Ergo wallets?

vsubhuman commented 3 years ago

Hi! Sorry for a late response. Any request like that is a weird case tp handle, because I am sure technically that would not be that big of a problem if really needed, but then there are two main points to consider:

  1. What is the demand for a feature like that? Since we have to think about the priorities
  2. I'd be really anxious about adding any kind of functionality that might excessively complicate important flows like the wallet restoration with features that might confuse people in case they are not familiar with it right away.

I can express two ideas about how I'd go about resolving this issue:

  1. We have the "Claim / Tranfer" tab on the main left sidebar, which suprisingly does not work for Ergo wallets at all, from what I can see. It supposed to provide functionality to enter mnemonics of some other wallet and it will transfer the entire balance of that other wallet to the selected Yoroi wallet. In Cardano we are using this section for backward compatibility with all various sorts of different wallets that might have existed over the years, so users can transfer from them without even opening that wallet itself (especially good for full nodes). I'd be up to implementing this section for Ergo as well (need to clarify first tho that there are no technical blockers I might be missing) and then we could support the mnemonics password there. That seems like a good middle-ground fallback option to me.

  2. If there's enough demand from the community, we would definitely have to consider having the password on the main restoring flow as well. So maybe a topic must be created on the forum or on reddit group with a question for the community to vote if something like that is needed or not.

mailman451 commented 3 years ago

Hi, and thanks for the response!

I already had that slight feeling that this isn't a feature requested by a lot of people 😉. Although I (probably naïvely) think that implementing an additional mnemonic password shouldn't be too much of a hassle, I would agree that it definitely creates a potential for confusion as mnemonic passwords do exist out there, but are rarely used on any wallet applications for any coins.

As I wrote, creating a new wallet address without that extra password and tranferring the funds is probably the best way, just wanted to ask for that slight off-chance something was already in the works.

Also, I think a working "Claim / Transfer" function for Ergo would of course be useful and I'd vote for it (for normal wallets, as for my special case the mnemonic password would also have to be implemented here which brings up the point about complication again).

vsubhuman commented 3 years ago

Also, I think a working "Claim / Transfer" function for Ergo would of course be useful and I'd vote for it (for normal wallets, as for my special case the mnemonic password would also have to be implemented here which brings up the point about complication again).

Ah, but that's the point, what I'm saying is that I would totally agree to implement the mnemonic password feature, but only if we have it in the "Claim / Transfer" section, and not in the main "Restore Wallet" screen, because the "Claim / Transfer" section is specifically designed for various rare different wallet cases, while the main "Restore Wallet" screen prefferrably should be as simple and straightforward as possible.

Ok, then we will do some planning for having that "Claim / Transfer" section for Ergo and update this issue with some estimates, whenever possible 👌

mailman451 commented 3 years ago

Ah, but that's the point, what I'm saying is that I would totally agree to implement the mnemonic password feature, but only if we have it in the "Claim / Transfer" section, and not in the main "Restore Wallet" screen, because the "Claim / Transfer" section is specifically designed for various rare different wallet cases, while the main "Restore Wallet" screen prefferrably should be as simple and straightforward as possible.

Ok, now I got it. This would be great.

Ok, then we will do some planning for having that "Claim / Transfer" section for Ergo and update this issue with some estimates, whenever possible 👌

I'll continue monitoring this issue and if it gets implemented I'll try it out.