Emurgo / yoroi-frontend

Yoroi Wallet - Cardano ADA Wallet - Your gateway to the financial world (extension frontend)
https://yoroi-wallet.com/
MIT License
338 stars 100 forks source link

Gift Card Support #2525

Open RNDfr opened 2 years ago

RNDfr commented 2 years ago

It would be interesting to have Gift Card support in Yoroi, allowing gift card creation and tools to empty a gift card. I wrote a short article about Gift Cards on Reddit, and I made a live demo of a gift card generator here.

Here are the relevant points:

Gift cards are paper wallets intended to be gifted (fancy documents bundled with instruction and mnemonic words). Gift cards are potentially beneficial for the ecosystem since they allow to easily gift Cardano to people who don’t own a wallet or an exchange account (thus good for adoption).

The main risk with Gift Cards is that the person receiving the funds could use the restored wallet as its own (thus putting more funds on an insecure wallet).

Here are three Gift Card features that could be integrated into Yoroi:

  1. Gift Card Generation: A menu to generate a paper wallet bundled with instructions.
  2. Gift Card Restoration: A menu to automatically restore and empty a gift card to a secure wallet.
  3. Gift Card Detection: A feature that detect when a gift card is restored (in the classic wallet restore menu) and propose a Gift Card restoration (2.) instead.

Concerning (3.): one way to detect if a restored wallet is a Gift Card would be to generate every Gift Card with 'gift' as their first word. However, it would reduce the wallet possibilities from 2048^24 to 2048^23 (a potential security risk).

I posted a Gift Card Standard proposal on GitHub, which could be used as a joint base for different services willing to integrate gift cards.

vsubhuman commented 2 years ago

Hi, @RNDfr. If I understood correctly the main idea is to have a paper-wallet that is prohibited to be restored into a wallet directly and only can be "redeemed" into a separate wallet, is that correct?

If so then this might be interesting, thank you for the suggestion. We gotta look into more details and possibilities for now.

I posted a Gift Card Standard proposal on GitHub, which could be used as a joint base for different services willing to integrate gift cards.

For a standard that various wallets would pay attention to you can try proposing a new CIP: https://github.com/cardano-foundation/CIPs

Check out PRs there, new conventions and ideas can be proposed with no problem, just gotta try creating a draft specification with enough details and see for any feedback from the community.

RNDfr commented 2 years ago

Hi, @vsubhuman yes that's the idea.

For a standard that various wallets would pay attention to you can try proposing a new CIP: https://github.com/cardano-foundation/CIPs

I will look into that, thanks!

vsubhuman commented 2 years ago

Doable and agreed internally as a good idea, but a CIP really needs to be created first with the actual technical spec on how that would be implemented so other wallets can support as well.

RNDfr commented 2 years ago

I posted a CIP proposal on the Cardano forum.

edit: I had to repost because of the automated spam filter: CIP proposal