search

Emurgo / yoroi-frontend

Yoroi Wallet - Cardano ADA Wallet - Your gateway to the financial world (extension frontend)
https://yoroi-wallet.com/
MIT License
337 stars 100 forks source link

Yoroi loading slowly #2650

Open Smedzlatko opened 2 years ago

Smedzlatko commented 2 years ago

Hi, I am using the latest version of Brave 1.34.80 (tried on Chrome/Chromium as well) and Yoroi loads very slowly for me (it takes 1 minute to load the wallet). When I try to send/receive tx, it takes several seconds as well and the FE is constantly freezing. This UX renders Yoroi pretty much unusable at the moment.

vsubhuman commented 2 years ago

New version 4.9 is right about to be released and it contains multiple performance improvements that might resolve this issue at least partially

Smedzlatko commented 2 years ago

So, I just updated to latest version (4.9) and apart from Yoroi requiring new permissions (read and modify data on all websites? Why is that needed?), ti is still terribly slow. Loading time on my 32GB RAM took 42s, which is worse than bad.

vsubhuman commented 2 years ago

So, I just updated to latest version (4.9) and apart from Yoroi requiring new permissions (read and modify data on all websites? Why is that needed?), ti is still terribly slow. Loading time on my 32GB RAM took 42s, which is worse than bad.

The permission is needed for the new dapp-connector feature which is being enabled in the next release which injects the wallet API for dapps (like metamask).

We are trying to investigate that slowing down, which seems to be caused by chrome as the same exact version of the application in the test mode also on chrome does not have this problem. Will notify in this issue when any new information or development comes up

dchevell commented 2 years ago

@vsubhuman with respect, this an unacceptable required permission for this sort of app. Will you be making these optional? I will not be enabling or accepting the permission changes for the current version.

Edit: let me file an issue instead of derailing this discussion :)

vsubhuman commented 2 years ago

@vsubhuman with respect, this an unacceptable required permission for this sort of app. Will you be making these optional? I will not be enabling or accepting the permission changes for the current version.

Edit: let me file an issue instead of derailing this discussion :)

Answered in the new separate issue: https://github.com/Emurgo/yoroi-frontend/issues/2655#issuecomment-1011864879

vsubhuman commented 2 years ago

So, I just updated to latest version (4.9) and apart from Yoroi requiring new permissions (read and modify data on all websites? Why is that needed?), ti is still terribly slow. Loading time on my 32GB RAM took 42s, which is worse than bad.

The permission is needed for the new dapp-connector feature which is being enabled in the next release which injects the wallet API for dapps (like metamask).

We are trying to investigate that slowing down, which seems to be caused by chrome as the same exact version of the application in the test mode also on chrome does not have this problem. Will notify in this issue when any new information or development comes up

Back to the original issue. Apart from the production version on Chrome we have a test build for chrome or a production version for Firefox, both those versions built from the same exact version and same exact codebase are loading in like two seconds. Only production Chrome version has this loading issue and we are trying to communicate with Google about potential causes for this, but they are usually little to no help. This is being investigated at priority.

Smedzlatko commented 2 years ago

Thanks for the update, I am currently using Brave 1.34.80 and I am experiencing very long loading times (30s+). It probably runs on the same version of Chromium underneath as latest Chrome so I imagine it will have some common cause. Perhaps you can test this for the version of Chromium used in these versions?

Smedzlatko commented 2 years ago

Are there any news on this issue? It has been over month since I was able to use Yoroi and I had to migrate to other wallet (ccVault). Yoroi is COMPLETELY unusable due to this issue. Loading wallet takes 2 mintues now on latest Brave/Chrome (I have 32GB RAM and i7 so definitely not issue with hardware). Yoroi freezes and crashes when performing such simple operations like switching tabs. Is there any hope that this will improve anytime soon or shall we give up and abandon it completely?

kamisenpai commented 2 years ago

I have the same issue mostly. It loads in like 30 seconds and then it's really slow. Takes like 10 seconds to respond to my clicks. Used the chrome addon until now. Tried it with firefox and it's still slow and it also slows my entire browser. I doubt it's my hardware since I have a ryzen 3700 and 32gb RAM. Any updates on this?

Smedzlatko commented 2 years ago

I have the latest version of Yoroi and this issue still persists (on two of my PCs). I gave up on Yoroi a long time ago since it is almost unusable because of this problem and there are other wallets without issues and more features.

kamisenpai commented 2 years ago

I think I might do the same. But in case the dev is still reading these, it might have something to do with the wallet itself. The only page I have problems on is the transactions page. If I load that up it becomes extremely slow. I can also add that I think I have a really old wallet. (more than a year for sure) Hope that helps.